Commit 539bb6a2 authored by Philipp Zabel's avatar Philipp Zabel

drm/imx: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

Using the for_each_... macro should make the code bit shorter and
easier to read. This patch also properly decrements the endpoint node
reference count before returning out of the loop.
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 7416f4e3
...@@ -439,7 +439,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, ...@@ -439,7 +439,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
struct drm_encoder *encoder) struct drm_encoder *encoder)
{ {
struct imx_drm_crtc *imx_crtc = imx_drm_find_crtc(encoder->crtc); struct imx_drm_crtc *imx_crtc = imx_drm_find_crtc(encoder->crtc);
struct device_node *ep = NULL; struct device_node *ep;
struct of_endpoint endpoint; struct of_endpoint endpoint;
struct device_node *port; struct device_node *port;
int ret; int ret;
...@@ -447,18 +447,15 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, ...@@ -447,18 +447,15 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
if (!node || !imx_crtc) if (!node || !imx_crtc)
return -EINVAL; return -EINVAL;
do { for_each_endpoint_of_node(node, ep) {
ep = of_graph_get_next_endpoint(node, ep);
if (!ep)
break;
port = of_graph_get_remote_port(ep); port = of_graph_get_remote_port(ep);
of_node_put(port); of_node_put(port);
if (port == imx_crtc->crtc->port) { if (port == imx_crtc->crtc->port) {
ret = of_graph_parse_endpoint(ep, &endpoint); ret = of_graph_parse_endpoint(ep, &endpoint);
of_node_put(ep);
return ret ? ret : endpoint.port; return ret ? ret : endpoint.port;
} }
} while (ep); }
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment