Commit 53eac7a8 authored by Peter Xu's avatar Peter Xu Committed by Paolo Bonzini

KVM: Fix kvm_clear_dirty_log_protect off-by-(minus-)one

Just imaging the case where num_pages < BITS_PER_LONG, then the loop
will be skipped while it shouldn't.
Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
Fixes: 2a31b9dbSigned-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 4ddc9204
...@@ -1264,8 +1264,8 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, ...@@ -1264,8 +1264,8 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm,
return -EFAULT; return -EFAULT;
spin_lock(&kvm->mmu_lock); spin_lock(&kvm->mmu_lock);
for (offset = log->first_page, for (offset = log->first_page, i = offset / BITS_PER_LONG,
i = offset / BITS_PER_LONG, n = log->num_pages / BITS_PER_LONG; n--; n = DIV_ROUND_UP(log->num_pages, BITS_PER_LONG); n--;
i++, offset += BITS_PER_LONG) { i++, offset += BITS_PER_LONG) {
unsigned long mask = *dirty_bitmap_buffer++; unsigned long mask = *dirty_bitmap_buffer++;
atomic_long_t *p = (atomic_long_t *) &dirty_bitmap[i]; atomic_long_t *p = (atomic_long_t *) &dirty_bitmap[i];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment