Commit 53fddb66 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Dmitry Torokhov

Input: aiptek - replace GFP_ATOMIC with GFP_KERNEL in aiptek_probe()

aiptek_probe() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 7a082a24
...@@ -1712,7 +1712,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id) ...@@ -1712,7 +1712,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
} }
aiptek->data = usb_alloc_coherent(usbdev, AIPTEK_PACKET_LENGTH, aiptek->data = usb_alloc_coherent(usbdev, AIPTEK_PACKET_LENGTH,
GFP_ATOMIC, &aiptek->data_dma); GFP_KERNEL, &aiptek->data_dma);
if (!aiptek->data) { if (!aiptek->data) {
dev_warn(&intf->dev, "cannot allocate usb buffer\n"); dev_warn(&intf->dev, "cannot allocate usb buffer\n");
goto fail1; goto fail1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment