Commit 540effa7 authored by Paul Fertser's avatar Paul Fertser Committed by Guenter Roeck

hwmon: (tmp421) report /PVLD condition as fault

For both local and remote sensors all the supported ICs can report an
"undervoltage lockout" condition which means the conversion wasn't
properly performed due to insufficient power supply voltage and so the
measurement results can't be trusted.

Fixes: 9410700b ("hwmon: Add driver for Texas Instruments TMP421/422/423 sensor chips")
Signed-off-by: default avatarPaul Fertser <fercerpav@gmail.com>
Link: https://lore.kernel.org/r/20210924093011.26083-2-fercerpav@gmail.comSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2938b297
...@@ -179,10 +179,10 @@ static int tmp421_read(struct device *dev, enum hwmon_sensor_types type, ...@@ -179,10 +179,10 @@ static int tmp421_read(struct device *dev, enum hwmon_sensor_types type,
return 0; return 0;
case hwmon_temp_fault: case hwmon_temp_fault:
/* /*
* The OPEN bit signals a fault. This is bit 0 of the temperature * Any of OPEN or /PVLD bits indicate a hardware mulfunction
* register (low byte). * and the conversion result may be incorrect
*/ */
*val = tmp421->temp[channel] & 0x01; *val = !!(tmp421->temp[channel] & 0x03);
return 0; return 0;
default: default:
return -EOPNOTSUPP; return -EOPNOTSUPP;
...@@ -195,9 +195,6 @@ static umode_t tmp421_is_visible(const void *data, enum hwmon_sensor_types type, ...@@ -195,9 +195,6 @@ static umode_t tmp421_is_visible(const void *data, enum hwmon_sensor_types type,
{ {
switch (attr) { switch (attr) {
case hwmon_temp_fault: case hwmon_temp_fault:
if (channel == 0)
return 0;
return 0444;
case hwmon_temp_input: case hwmon_temp_input:
return 0444; return 0444;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment