Commit 54f4e11a authored by Florian Mickler's avatar Florian Mickler Committed by Mauro Carvalho Chehab

[media] a800: get rid of on-stack dma buffers

usb_control_msg initiates (and waits for completion of) a dma transfer using
the supplied buffer. That buffer thus has to be seperately allocated on
the heap.

In lib/dma_debug.c the function check_for_stack even warns about it:
	WARNING: at lib/dma-debug.c:866 check_for_stack

Note: This change is tested to compile only, as I don't have the hardware.
Signed-off-by: default avatarFlorian Mickler <florian@mickler.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ca738775
...@@ -78,17 +78,26 @@ static struct rc_map_table rc_map_a800_table[] = { ...@@ -78,17 +78,26 @@ static struct rc_map_table rc_map_a800_table[] = {
static int a800_rc_query(struct dvb_usb_device *d, u32 *event, int *state) static int a800_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
{ {
u8 key[5]; int ret;
u8 *key = kmalloc(5, GFP_KERNEL);
if (!key)
return -ENOMEM;
if (usb_control_msg(d->udev,usb_rcvctrlpipe(d->udev,0), if (usb_control_msg(d->udev,usb_rcvctrlpipe(d->udev,0),
0x04, USB_TYPE_VENDOR | USB_DIR_IN, 0, 0, key, 5, 0x04, USB_TYPE_VENDOR | USB_DIR_IN, 0, 0, key, 5,
2000) != 5) 2000) != 5) {
return -ENODEV; ret = -ENODEV;
goto out;
}
/* call the universal NEC remote processor, to find out the key's state and event */ /* call the universal NEC remote processor, to find out the key's state and event */
dvb_usb_nec_rc_key_to_event(d,key,event,state); dvb_usb_nec_rc_key_to_event(d,key,event,state);
if (key[0] != 0) if (key[0] != 0)
deb_rc("key: %x %x %x %x %x\n",key[0],key[1],key[2],key[3],key[4]); deb_rc("key: %x %x %x %x %x\n",key[0],key[1],key[2],key[3],key[4]);
return 0; ret = 0;
out:
kfree(key);
return ret;
} }
/* USB Driver stuff */ /* USB Driver stuff */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment