Commit 55244930 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Luis Henriques

remoteproc: avoid stack overflow in debugfs file

commit 92792e48 upstream.

Recent gcc versions warn about reading from a negative offset of
an on-stack array:

drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb8 ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 0c6a3e1b
...@@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf, ...@@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10]; char buf[10];
int ret; int ret;
if (count > sizeof(buf)) if (count < 1 || count > sizeof(buf))
return count; return count;
ret = copy_from_user(buf, user_buf, count); ret = copy_from_user(buf, user_buf, count);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment