Commit 559cef99 authored by Rajkumar Manoharan's avatar Rajkumar Manoharan Committed by Johannes Berg

mac80211: cleanup offchannel_ps_enable argument

The 'tell_ap' argument is always true. So that remove it
and simplify the function.
Signed-off-by: default avatarRajkumar Manoharan <rmanohar@qca.qualcomm.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 7ebfa469
...@@ -25,8 +25,7 @@ ...@@ -25,8 +25,7 @@
* because we *may* be doing work on-operating channel, and want our * because we *may* be doing work on-operating channel, and want our
* hardware unconditionally awake, but still let the AP send us normal frames. * hardware unconditionally awake, but still let the AP send us normal frames.
*/ */
static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata, static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata)
bool tell_ap)
{ {
struct ieee80211_local *local = sdata->local; struct ieee80211_local *local = sdata->local;
struct ieee80211_if_managed *ifmgd = &sdata->u.mgd; struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
...@@ -47,8 +46,8 @@ static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata, ...@@ -47,8 +46,8 @@ static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata,
ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS); ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
} }
if (tell_ap && (!local->offchannel_ps_enabled || if (!local->offchannel_ps_enabled ||
!(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))) !(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
/* /*
* If power save was enabled, no need to send a nullfunc * If power save was enabled, no need to send a nullfunc
* frame because AP knows that we are sleeping. But if the * frame because AP knows that we are sleeping. But if the
...@@ -133,7 +132,7 @@ void ieee80211_offchannel_stop_vifs(struct ieee80211_local *local, ...@@ -133,7 +132,7 @@ void ieee80211_offchannel_stop_vifs(struct ieee80211_local *local,
if (offchannel_ps_enable && if (offchannel_ps_enable &&
(sdata->vif.type == NL80211_IFTYPE_STATION) && (sdata->vif.type == NL80211_IFTYPE_STATION) &&
sdata->u.mgd.associated) sdata->u.mgd.associated)
ieee80211_offchannel_ps_enable(sdata, true); ieee80211_offchannel_ps_enable(sdata);
} }
} }
mutex_unlock(&local->iflist_mtx); mutex_unlock(&local->iflist_mtx);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment