Commit 564cf2f3 authored by Matthieu Baerts's avatar Matthieu Baerts Committed by David S. Miller

mptcp: fix "fn parameter not described" warnings

Obtained with:

  $ make W=1 net/mptcp/token.o
  net/mptcp/token.c:53: warning: Function parameter or member 'req' not described in 'mptcp_token_new_request'
  net/mptcp/token.c:98: warning: Function parameter or member 'sk' not described in 'mptcp_token_new_connect'
  net/mptcp/token.c:133: warning: Function parameter or member 'conn' not described in 'mptcp_token_new_accept'
  net/mptcp/token.c:178: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy_request'
  net/mptcp/token.c:191: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy'

Fixes: 79c0949e (mptcp: Add key generation and token tree)
Fixes: 58b09919 (mptcp: create msk early)
Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent de06f573
...@@ -40,7 +40,7 @@ static int token_used __read_mostly; ...@@ -40,7 +40,7 @@ static int token_used __read_mostly;
/** /**
* mptcp_token_new_request - create new key/idsn/token for subflow_request * mptcp_token_new_request - create new key/idsn/token for subflow_request
* @req - the request socket * @req: the request socket
* *
* This function is called when a new mptcp connection is coming in. * This function is called when a new mptcp connection is coming in.
* *
...@@ -80,7 +80,7 @@ int mptcp_token_new_request(struct request_sock *req) ...@@ -80,7 +80,7 @@ int mptcp_token_new_request(struct request_sock *req)
/** /**
* mptcp_token_new_connect - create new key/idsn/token for subflow * mptcp_token_new_connect - create new key/idsn/token for subflow
* @sk - the socket that will initiate a connection * @sk: the socket that will initiate a connection
* *
* This function is called when a new outgoing mptcp connection is * This function is called when a new outgoing mptcp connection is
* initiated. * initiated.
...@@ -125,6 +125,7 @@ int mptcp_token_new_connect(struct sock *sk) ...@@ -125,6 +125,7 @@ int mptcp_token_new_connect(struct sock *sk)
/** /**
* mptcp_token_new_accept - insert token for later processing * mptcp_token_new_accept - insert token for later processing
* @token: the token to insert to the tree * @token: the token to insert to the tree
* @conn: the just cloned socket linked to the new connection
* *
* Called when a SYN packet creates a new logical connection, i.e. * Called when a SYN packet creates a new logical connection, i.e.
* is not a join request. * is not a join request.
...@@ -169,7 +170,7 @@ struct mptcp_sock *mptcp_token_get_sock(u32 token) ...@@ -169,7 +170,7 @@ struct mptcp_sock *mptcp_token_get_sock(u32 token)
/** /**
* mptcp_token_destroy_request - remove mptcp connection/token * mptcp_token_destroy_request - remove mptcp connection/token
* @token - token of mptcp connection to remove * @token: token of mptcp connection to remove
* *
* Remove not-yet-fully-established incoming connection identified * Remove not-yet-fully-established incoming connection identified
* by @token. * by @token.
...@@ -183,7 +184,7 @@ void mptcp_token_destroy_request(u32 token) ...@@ -183,7 +184,7 @@ void mptcp_token_destroy_request(u32 token)
/** /**
* mptcp_token_destroy - remove mptcp connection/token * mptcp_token_destroy - remove mptcp connection/token
* @token - token of mptcp connection to remove * @token: token of mptcp connection to remove
* *
* Remove the connection identified by @token. * Remove the connection identified by @token.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment