Commit 56537faf authored by Nathan Lynch's avatar Nathan Lynch Committed by Michael Ellerman

powerpc: fix unbalanced node refcount in check_kvm_guest()

When check_kvm_guest() succeeds in looking up a /hypervisor OF node, it
returns without performing a matching put for the lookup, leaving the
node's reference count elevated.

Add the necessary call to of_node_put(), rearranging the code slightly to
avoid repetition or goto.

Fixes: 107c5500 ("powerpc/pseries: Add KVM guest doorbell restrictions")
Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Reviewed-by: default avatarTyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210928124550.132020-1-nathanl@linux.ibm.com
parent f2719b26
...@@ -31,11 +31,10 @@ int __init check_kvm_guest(void) ...@@ -31,11 +31,10 @@ int __init check_kvm_guest(void)
if (!hyper_node) if (!hyper_node)
return 0; return 0;
if (!of_device_is_compatible(hyper_node, "linux,kvm")) if (of_device_is_compatible(hyper_node, "linux,kvm"))
return 0; static_branch_enable(&kvm_guest);
static_branch_enable(&kvm_guest);
of_node_put(hyper_node);
return 0; return 0;
} }
core_initcall(check_kvm_guest); // before kvm_guest_init() core_initcall(check_kvm_guest); // before kvm_guest_init()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment