Commit 568fe849 authored by Ziyang Xuan's avatar Ziyang Xuan Committed by Jakub Kicinski

ipv4: Fix error return code in fib_table_insert()

In fib_table_insert(), if the alias was already inserted, but node not
exist, the error code should be set before return from error handling path.

Fixes: a6c76c17 ("ipv4: Notify route after insertion to the routing table")
Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Link: https://lore.kernel.org/r/20221120072838.2167047-1-william.xuanziyang@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dddf26df
...@@ -1381,8 +1381,10 @@ int fib_table_insert(struct net *net, struct fib_table *tb, ...@@ -1381,8 +1381,10 @@ int fib_table_insert(struct net *net, struct fib_table *tb,
/* The alias was already inserted, so the node must exist. */ /* The alias was already inserted, so the node must exist. */
l = l ? l : fib_find_node(t, &tp, key); l = l ? l : fib_find_node(t, &tp, key);
if (WARN_ON_ONCE(!l)) if (WARN_ON_ONCE(!l)) {
err = -ENOENT;
goto out_free_new_fa; goto out_free_new_fa;
}
if (fib_find_alias(&l->leaf, new_fa->fa_slen, 0, 0, tb->tb_id, true) == if (fib_find_alias(&l->leaf, new_fa->fa_slen, 0, 0, tb->tb_id, true) ==
new_fa) { new_fa) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment