Commit 572cf7d7 authored by Tony Lindgren's avatar Tony Lindgren

ARM: dts: Improve omap l4per idling with wlcore edge sensitive interrupt

The wl1835mod.pdf data sheet says this pretty clearly for WL_IRQ line:

"WLAN SDIO out-of-band interrupt line. Set to rising edge (active high)
by default."

And it seems this interrupt can be optionally configured to use falling
edge too since commit bd763482 ("wl18xx: wlan_irq: support platform
dependent interrupt types").

On omap4, if the wlcore interrupt is configured as level instead of edge,
L4PER will stop doing hardware based idling after ifconfig wlan0 down is
done and the WL_EN line is pulled down.

The symptoms show up with L4PER status registers no longer showing the
IDLEST bits as 2 but as 0 for all the active GPIO banks and for
L4PER_CLKCTRL. Also the l4per_pwrdm RET count stops increasing in
the /sys/kernel/debug/pm_debug/count.

While there is also probably a GPIO related issue that needs to be
still fixed, this change gets us to the point where we can have L4PER
idling.

I'm guessing wlcore was at some point configured to use level interrupts
because of edge handling issues in gpio-omap. However, with the recent
fixes to gpio-omap the edge interrupts seem to be working just fine.

Let's change it for all omap boards with wlcore interrupt set as level.

Cc: Dave Gerlach <d-gerlach@ti.com>
Cc: Eyal Reizer <eyalr@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
[tony@atomide.com updated comments a bit for gpio issue]
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 382ceeaa
...@@ -396,7 +396,7 @@ wlcore: wlcore@2 { ...@@ -396,7 +396,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1835"; compatible = "ti,wl1835";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio3>; interrupt-parent = <&gpio3>;
interrupts = <7 IRQ_TYPE_LEVEL_HIGH>; interrupts = <7 IRQ_TYPE_EDGE_RISING>;
}; };
}; };
......
...@@ -778,7 +778,7 @@ wlcore: wlcore@0 { ...@@ -778,7 +778,7 @@ wlcore: wlcore@0 {
compatible = "ti,wl1835"; compatible = "ti,wl1835";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio3>; interrupt-parent = <&gpio3>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; interrupts = <17 IRQ_TYPE_EDGE_RISING>;
}; };
}; };
......
...@@ -690,7 +690,7 @@ wlcore: wlcore@2 { ...@@ -690,7 +690,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio0>; interrupt-parent = <&gpio0>;
interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */ interrupts = <31 IRQ_TYPE_EDGE_RISING>; /* gpio 31 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
......
...@@ -790,7 +790,7 @@ wlcore: wlcore@0 { ...@@ -790,7 +790,7 @@ wlcore: wlcore@0 {
compatible = "ti,wl1835"; compatible = "ti,wl1835";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <23 IRQ_TYPE_LEVEL_HIGH>; interrupts = <23 IRQ_TYPE_EDGE_RISING>;
}; };
}; };
......
...@@ -142,7 +142,7 @@ wlcore: wlcore@2 { ...@@ -142,7 +142,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1273"; compatible = "ti,wl1273";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; /* gpio 2 */ interrupts = <2 IRQ_TYPE_EDGE_RISING>; /* gpio 2 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
}; };
}; };
......
...@@ -48,7 +48,7 @@ wlcore: wlcore@2 { ...@@ -48,7 +48,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1283"; compatible = "ti,wl1283";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; /* gpio 152 */ interrupts = <24 IRQ_TYPE_EDGE_RISING>; /* gpio 152 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
tcxo-clock-frequency = <26000000>; tcxo-clock-frequency = <26000000>;
}; };
......
...@@ -141,7 +141,7 @@ wlcore: wlcore@2 { ...@@ -141,7 +141,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; /* gpio 145 */ interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* gpio 145 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
......
...@@ -81,7 +81,7 @@ wlcore: wlcore@2 { ...@@ -81,7 +81,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; /* gpio 136 */ interrupts = <8 IRQ_TYPE_EDGE_RISING>; /* gpio 136 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
......
...@@ -133,7 +133,7 @@ wlcore: wlcore@2 { ...@@ -133,7 +133,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* gpio 149 */ interrupts = <21 IRQ_TYPE_EDGE_RISING>; /* gpio 149 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
......
...@@ -49,6 +49,6 @@ wlcore: wlcore@2 { ...@@ -49,6 +49,6 @@ wlcore: wlcore@2 {
compatible = "ti,wl1835"; compatible = "ti,wl1835";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio6>; interrupt-parent = <&gpio6>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; /* gpio 177 */ interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* gpio 177 */
}; };
}; };
...@@ -71,6 +71,6 @@ wlcore: wlcore@2 { ...@@ -71,6 +71,6 @@ wlcore: wlcore@2 {
compatible = "ti,wl1835"; compatible = "ti,wl1835";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; /* gpio 136 */ interrupts = <8 IRQ_TYPE_EDGE_RISING>; /* gpio 136 */
}; };
}; };
...@@ -202,7 +202,7 @@ wlcore: wlcore@2 { ...@@ -202,7 +202,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio6>; interrupt-parent = <&gpio6>;
interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; /* gpio 162 */ interrupts = <2 IRQ_TYPE_EDGE_RISING>; /* gpio 162 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
}; };
}; };
......
...@@ -372,7 +372,7 @@ wlcore: wlcore@2 { ...@@ -372,7 +372,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1285", "ti,wl1283"; compatible = "ti,wl1285", "ti,wl1283";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio4>; interrupt-parent = <&gpio4>;
interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; /* gpio100 */ interrupts = <4 IRQ_TYPE_EDGE_RISING>; /* gpio100 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
tcxo-clock-frequency = <26000000>; tcxo-clock-frequency = <26000000>;
}; };
......
...@@ -464,7 +464,7 @@ wlcore: wlcore@2 { ...@@ -464,7 +464,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio2>; interrupt-parent = <&gpio2>;
interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* gpio 53 */ interrupts = <21 IRQ_TYPE_EDGE_RISING>; /* gpio 53 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
......
...@@ -493,7 +493,7 @@ wlcore: wlcore@2 { ...@@ -493,7 +493,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1281"; compatible = "ti,wl1281";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* gpio 53 */ interrupts = <21 IRQ_TYPE_EDGE_RISING>; /* gpio 53 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
tcxo-clock-frequency = <26000000>; tcxo-clock-frequency = <26000000>;
}; };
......
...@@ -72,7 +72,7 @@ wlcore: wlcore@2 { ...@@ -72,7 +72,7 @@ wlcore: wlcore@2 {
compatible = "ti,wl1271"; compatible = "ti,wl1271";
reg = <2>; reg = <2>;
interrupt-parent = <&gpio2>; interrupt-parent = <&gpio2>;
interrupts = <9 IRQ_TYPE_LEVEL_HIGH>; /* gpio 41 */ interrupts = <9 IRQ_TYPE_EDGE_RISING>; /* gpio 41 */
ref-clock-frequency = <38400000>; ref-clock-frequency = <38400000>;
}; };
}; };
...@@ -364,7 +364,7 @@ wlcore: wlcore@2 { ...@@ -364,7 +364,7 @@ wlcore: wlcore@2 {
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&wlcore_irq_pin>; pinctrl-0 = <&wlcore_irq_pin>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <14 IRQ_TYPE_LEVEL_HIGH>; /* gpio 14 */ interrupts = <14 IRQ_TYPE_EDGE_RISING>; /* gpio 14 */
ref-clock-frequency = <26000000>; ref-clock-frequency = <26000000>;
}; };
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment