Commit 5779aa2d authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'fsverity-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt

Pull fsverity updates from Eric Biggers:
 "Minor changes to convert uses of kmap() to kmap_local_page()"

* tag 'fsverity-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt:
  fs-verity: use kmap_local_page() instead of kmap()
  fs-verity: use memcpy_from_page()
parents 438b2cdd 8377e8a2
...@@ -53,14 +53,14 @@ static int fsverity_read_merkle_tree(struct inode *inode, ...@@ -53,14 +53,14 @@ static int fsverity_read_merkle_tree(struct inode *inode,
break; break;
} }
virt = kmap(page); virt = kmap_local_page(page);
if (copy_to_user(buf, virt + offs_in_page, bytes_to_copy)) { if (copy_to_user(buf, virt + offs_in_page, bytes_to_copy)) {
kunmap(page); kunmap_local(virt);
put_page(page); put_page(page);
err = -EFAULT; err = -EFAULT;
break; break;
} }
kunmap(page); kunmap_local(virt);
put_page(page); put_page(page);
retval += bytes_to_copy; retval += bytes_to_copy;
......
...@@ -39,16 +39,6 @@ static void hash_at_level(const struct merkle_tree_params *params, ...@@ -39,16 +39,6 @@ static void hash_at_level(const struct merkle_tree_params *params,
(params->log_blocksize - params->log_arity); (params->log_blocksize - params->log_arity);
} }
/* Extract a hash from a hash page */
static void extract_hash(struct page *hpage, unsigned int hoffset,
unsigned int hsize, u8 *out)
{
void *virt = kmap_atomic(hpage);
memcpy(out, virt + hoffset, hsize);
kunmap_atomic(virt);
}
static inline int cmp_hashes(const struct fsverity_info *vi, static inline int cmp_hashes(const struct fsverity_info *vi,
const u8 *want_hash, const u8 *real_hash, const u8 *want_hash, const u8 *real_hash,
pgoff_t index, int level) pgoff_t index, int level)
...@@ -129,7 +119,7 @@ static bool verify_page(struct inode *inode, const struct fsverity_info *vi, ...@@ -129,7 +119,7 @@ static bool verify_page(struct inode *inode, const struct fsverity_info *vi,
} }
if (PageChecked(hpage)) { if (PageChecked(hpage)) {
extract_hash(hpage, hoffset, hsize, _want_hash); memcpy_from_page(_want_hash, hpage, hoffset, hsize);
want_hash = _want_hash; want_hash = _want_hash;
put_page(hpage); put_page(hpage);
pr_debug_ratelimited("Hash page already checked, want %s:%*phN\n", pr_debug_ratelimited("Hash page already checked, want %s:%*phN\n",
...@@ -158,7 +148,7 @@ static bool verify_page(struct inode *inode, const struct fsverity_info *vi, ...@@ -158,7 +148,7 @@ static bool verify_page(struct inode *inode, const struct fsverity_info *vi,
if (err) if (err)
goto out; goto out;
SetPageChecked(hpage); SetPageChecked(hpage);
extract_hash(hpage, hoffset, hsize, _want_hash); memcpy_from_page(_want_hash, hpage, hoffset, hsize);
want_hash = _want_hash; want_hash = _want_hash;
put_page(hpage); put_page(hpage);
pr_debug("Verified hash page at level %d, now want %s:%*phN\n", pr_debug("Verified hash page at level %d, now want %s:%*phN\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment