Commit 577ec789 authored by Michael Ellerman's avatar Michael Ellerman

powerpc/cell: Drop select of MEMORY_HOTPLUG

SPU_FS selects MEMORY_HOTPLUG, which is problematic because
MEMORY_HOTPLUG is user selectable, meaning we can end up with a broken
.config where MEMORY_HOTPLUG is enabled but its dependencies are not,
leading to build breakages.

The select of MEMORY_HOTPLUG for SPU_FS was added back in 2006, in
commit 4da30d15 ("[POWERPC] spufs: fix memory hotplug dependency").

However we reworked the spufs code and removed the dependency on memory
hotplug in 2007 in commit 78bde53e ("[POWERPC] spufs: remove need
for struct page for SPEs").

So drop the select as it's no longer needed and causes problems.
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 2db029ef
...@@ -46,7 +46,6 @@ config SPU_FS ...@@ -46,7 +46,6 @@ config SPU_FS
default m default m
depends on PPC_CELL depends on PPC_CELL
select SPU_BASE select SPU_BASE
select MEMORY_HOTPLUG
help help
The SPU file system is used to access Synergistic Processing The SPU file system is used to access Synergistic Processing
Units on machines implementing the Broadband Processor Units on machines implementing the Broadband Processor
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment