Commit 581382e3 authored by Archit Taneja's avatar Archit Taneja Committed by Tomi Valkeinen

drm/omap: fix modeset_init if a panel doesn't satisfy omapdrm requirements

modeset_init iterates through all the registered omapdss devices and has some
initial checks to see if the panel has a driver and the required driver ops for
it to be usable by omapdrm.

The function bails out from modeset_init if a panel doesn't meet the
requirements, and stops the registration of the future panels and encoders which
come after it, that isn't the correct thing to do, we should go through the rest
of the panels. Replace the 'return's with 'continue's.
Signed-off-by: default avatarArchit Taneja <archit@ti.com>
Reviewed-by: default avatarRob Clark <robdclark@gmail.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 2c6360fb
...@@ -121,7 +121,7 @@ static int omap_modeset_init(struct drm_device *dev) ...@@ -121,7 +121,7 @@ static int omap_modeset_init(struct drm_device *dev)
if (!dssdev->driver) { if (!dssdev->driver) {
dev_warn(dev->dev, "%s has no driver.. skipping it\n", dev_warn(dev->dev, "%s has no driver.. skipping it\n",
dssdev->name); dssdev->name);
return 0; continue;
} }
if (!(dssdev->driver->get_timings || if (!(dssdev->driver->get_timings ||
...@@ -129,7 +129,7 @@ static int omap_modeset_init(struct drm_device *dev) ...@@ -129,7 +129,7 @@ static int omap_modeset_init(struct drm_device *dev)
dev_warn(dev->dev, "%s driver does not support " dev_warn(dev->dev, "%s driver does not support "
"get_timings or read_edid.. skipping it!\n", "get_timings or read_edid.. skipping it!\n",
dssdev->name); dssdev->name);
return 0; continue;
} }
encoder = omap_encoder_init(dev, dssdev); encoder = omap_encoder_init(dev, dssdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment