Commit 588558eb authored by Colin Ian King's avatar Colin Ian King Committed by John Johansen

apparmor: fix memory leak on buffer on error exit path

Currently on the error exit path the allocated buffer is not free'd
causing a memory leak. Fix this by kfree'ing it.

Detected by CoverityScan, CID#1466876 ("Resource leaks")

Fixes: 1180b4c7 ("apparmor: fix dangling symlinks to policy rawdata after replacement")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
parent 1180b4c7
...@@ -1497,8 +1497,10 @@ static char *gen_symlink_name(int depth, const char *dirname, const char *fname) ...@@ -1497,8 +1497,10 @@ static char *gen_symlink_name(int depth, const char *dirname, const char *fname)
} }
error = snprintf(s, size, "raw_data/%s/%s", dirname, fname); error = snprintf(s, size, "raw_data/%s/%s", dirname, fname);
if (error >= size || error < 0) if (error >= size || error < 0) {
kfree(buffer);
return ERR_PTR(-ENAMETOOLONG); return ERR_PTR(-ENAMETOOLONG);
}
return buffer; return buffer;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment