Commit 58cdff6e authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron

staging:iio:ad7192: Report channel offset

In bipolar mode there is a a binary offset of 2**(N-1) (with N being the number
of bits) on the reported value. Currently this value is subtracted when doing a
manual read. While this works for manual channel readings it does not work for
buffered mode. So report the offset in the channels offset property, which will
work in both modes.
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
parent a684a0c7
...@@ -826,8 +826,6 @@ static int ad7192_read_raw(struct iio_dev *indio_dev, ...@@ -826,8 +826,6 @@ static int ad7192_read_raw(struct iio_dev *indio_dev,
switch (chan->type) { switch (chan->type) {
case IIO_VOLTAGE: case IIO_VOLTAGE:
if (!unipolar)
*val -= (1 << (chan->scan_type.realbits - 1));
break; break;
case IIO_TEMP: case IIO_TEMP:
*val -= 0x800000; *val -= 0x800000;
...@@ -853,6 +851,12 @@ static int ad7192_read_raw(struct iio_dev *indio_dev, ...@@ -853,6 +851,12 @@ static int ad7192_read_raw(struct iio_dev *indio_dev,
default: default:
return -EINVAL; return -EINVAL;
} }
case IIO_CHAN_INFO_OFFSET:
if (!unipolar)
*val -= (1 << (chan->scan_type.realbits - 1));
else
*val = 0;
return IIO_VAL_INT;
} }
return -EINVAL; return -EINVAL;
...@@ -942,7 +946,8 @@ static const struct iio_info ad7195_info = { ...@@ -942,7 +946,8 @@ static const struct iio_info ad7195_info = {
.channel = _chan, \ .channel = _chan, \
.channel2 = _chan2, \ .channel2 = _chan2, \
.info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \ .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \
IIO_CHAN_INFO_SCALE_SHARED_BIT, \ IIO_CHAN_INFO_SCALE_SHARED_BIT | \
IIO_CHAN_INFO_OFFSET_SHARED_BIT, \
.address = _address, \ .address = _address, \
.scan_index = _si, \ .scan_index = _si, \
.scan_type = IIO_ST('u', 24, 32, 0)} .scan_type = IIO_ST('u', 24, 32, 0)}
...@@ -952,7 +957,8 @@ static const struct iio_info ad7195_info = { ...@@ -952,7 +957,8 @@ static const struct iio_info ad7195_info = {
.indexed = 1, \ .indexed = 1, \
.channel = _chan, \ .channel = _chan, \
.info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \ .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \
IIO_CHAN_INFO_SCALE_SHARED_BIT, \ IIO_CHAN_INFO_SCALE_SHARED_BIT | \
IIO_CHAN_INFO_OFFSET_SHARED_BIT, \
.address = _address, \ .address = _address, \
.scan_index = _si, \ .scan_index = _si, \
.scan_type = IIO_ST('u', 24, 32, 0)} .scan_type = IIO_ST('u', 24, 32, 0)}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment