Commit 596690e9 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller

ethtool: return error from ethnl_ops_begin if dev is NULL

Julian reported that after d43c65b0 Coverity complains about a
missing check whether dev is NULL in ethnl_ops_complete().
There doesn't seem to be any valid case where dev could be NULL when
calling ethnl_ops_begin(), therefore return an error if dev is NULL.

Fixes: d43c65b0 ("ethtool: runtime-resume netdev parent in ethnl_ops_begin")
Reported-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5c0418ed
......@@ -35,7 +35,7 @@ int ethnl_ops_begin(struct net_device *dev)
int ret;
if (!dev)
return 0;
return -ENODEV;
if (dev->dev.parent)
pm_runtime_get_sync(dev->dev.parent);
......@@ -61,7 +61,7 @@ int ethnl_ops_begin(struct net_device *dev)
void ethnl_ops_complete(struct net_device *dev)
{
if (dev && dev->ethtool_ops->complete)
if (dev->ethtool_ops->complete)
dev->ethtool_ops->complete(dev);
if (dev->dev.parent)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment