Commit 59cc8e0a authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

module: Properly propagate MODULE_STATE_COMING failure

Now that notifiers got unbroken; use the proper interface to handle
notifier errors and propagate them.

There were already MODULE_STATE_COMING notifiers that failed; notably:

 - jump_label_module_notifier()
 - tracepoint_module_notify()
 - bpf_event_notify()

By propagating this error, we fix those users.
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJessica Yu <jeyu@kernel.org>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20200818135804.444372853@infradead.org
parent 0340a6b7
...@@ -3792,9 +3792,13 @@ static int prepare_coming_module(struct module *mod) ...@@ -3792,9 +3792,13 @@ static int prepare_coming_module(struct module *mod)
if (err) if (err)
return err; return err;
blocking_notifier_call_chain(&module_notify_list, err = blocking_notifier_call_chain_robust(&module_notify_list,
MODULE_STATE_COMING, mod); MODULE_STATE_COMING, MODULE_STATE_GOING, mod);
return 0; err = notifier_to_errno(err);
if (err)
klp_module_going(mod);
return err;
} }
static int unknown_module_param_cb(char *param, char *val, const char *modname, static int unknown_module_param_cb(char *param, char *val, const char *modname,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment