Commit 59d84ca8 authored by Quentin Lambert's avatar Quentin Lambert Committed by Rafael J. Wysocki

PM / OPP / clk: Remove unnecessary OOM message

This patch reduces the kernel size by removing error messages that duplicate
the normal OOM message.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)

@@
identifier f,print,l;
expression e;
constant char[] c;
@@

e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(...);
if (e == NULL) {
  <+...
-  print(...,c,...);
  ... when any
(
  goto l;
|
  return ...;
)
  ...+> }
Signed-off-by: default avatarQuentin Lambert <lambert.quentin@gmail.com>
Acked-by: default avatarNishanth Menon <nm@ti.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 04bf1c7f
...@@ -855,7 +855,6 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, ...@@ -855,7 +855,6 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
fw_priv = kzalloc(sizeof(*fw_priv), GFP_KERNEL); fw_priv = kzalloc(sizeof(*fw_priv), GFP_KERNEL);
if (!fw_priv) { if (!fw_priv) {
dev_err(device, "%s: kmalloc failed\n", __func__);
fw_priv = ERR_PTR(-ENOMEM); fw_priv = ERR_PTR(-ENOMEM);
goto exit; goto exit;
} }
......
...@@ -81,10 +81,8 @@ static int __pm_clk_add(struct device *dev, const char *con_id, ...@@ -81,10 +81,8 @@ static int __pm_clk_add(struct device *dev, const char *con_id,
return -EINVAL; return -EINVAL;
ce = kzalloc(sizeof(*ce), GFP_KERNEL); ce = kzalloc(sizeof(*ce), GFP_KERNEL);
if (!ce) { if (!ce)
dev_err(dev, "Not enough memory for clock entry.\n");
return -ENOMEM; return -ENOMEM;
}
if (con_id) { if (con_id) {
ce->con_id = kstrdup(con_id, GFP_KERNEL); ce->con_id = kstrdup(con_id, GFP_KERNEL);
......
...@@ -474,10 +474,8 @@ static int _opp_add_dynamic(struct device *dev, unsigned long freq, ...@@ -474,10 +474,8 @@ static int _opp_add_dynamic(struct device *dev, unsigned long freq,
/* allocate new OPP node */ /* allocate new OPP node */
new_opp = kzalloc(sizeof(*new_opp), GFP_KERNEL); new_opp = kzalloc(sizeof(*new_opp), GFP_KERNEL);
if (!new_opp) { if (!new_opp)
dev_warn(dev, "%s: Unable to create new OPP node\n", __func__);
return -ENOMEM; return -ENOMEM;
}
/* Hold our list modification lock here */ /* Hold our list modification lock here */
mutex_lock(&dev_opp_list_lock); mutex_lock(&dev_opp_list_lock);
...@@ -695,10 +693,8 @@ static int _opp_set_availability(struct device *dev, unsigned long freq, ...@@ -695,10 +693,8 @@ static int _opp_set_availability(struct device *dev, unsigned long freq,
/* keep the node allocated */ /* keep the node allocated */
new_opp = kmalloc(sizeof(*new_opp), GFP_KERNEL); new_opp = kmalloc(sizeof(*new_opp), GFP_KERNEL);
if (!new_opp) { if (!new_opp)
dev_warn(dev, "%s: Unable to create OPP\n", __func__);
return -ENOMEM; return -ENOMEM;
}
mutex_lock(&dev_opp_list_lock); mutex_lock(&dev_opp_list_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment