Commit 5a1bef58 authored by Christophe Jaillet's avatar Christophe Jaillet Committed by Greg Kroah-Hartman

rt2x00usb: Fix error return code

commit 410280ba upstream.

We know that 'retval = 0' because it has been tested a few lines above.
So, if 'devm_kmalloc' fails, 0 will be returned instead of an error code.
Return -ENOMEM instead.

Fixes: 8b4c0009 ("rt2x00usb: Use usb anchor to manage URB")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ea288a69
...@@ -831,8 +831,10 @@ int rt2x00usb_probe(struct usb_interface *usb_intf, ...@@ -831,8 +831,10 @@ int rt2x00usb_probe(struct usb_interface *usb_intf,
rt2x00dev->anchor = devm_kmalloc(&usb_dev->dev, rt2x00dev->anchor = devm_kmalloc(&usb_dev->dev,
sizeof(struct usb_anchor), sizeof(struct usb_anchor),
GFP_KERNEL); GFP_KERNEL);
if (!rt2x00dev->anchor) if (!rt2x00dev->anchor) {
retval = -ENOMEM;
goto exit_free_reg; goto exit_free_reg;
}
init_usb_anchor(rt2x00dev->anchor); init_usb_anchor(rt2x00dev->anchor);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment