Commit 5a243894 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski

net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get()

of_parse_phandle() will increase the refcount of 'pcs_node', so add
of_node_put() before return from a5psw_pcs_get().

Fixes: 888cdb89 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220630014153.1888811-1-yangyingliang@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 34eff17e
...@@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw) ...@@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw)
} }
a5psw->pcs[reg] = pcs; a5psw->pcs[reg] = pcs;
of_node_put(pcs_node);
} }
of_node_put(ports); of_node_put(ports);
return 0; return 0;
free_pcs: free_pcs:
of_node_put(pcs_node);
of_node_put(port); of_node_put(port);
of_node_put(ports); of_node_put(ports);
a5psw_pcs_free(a5psw); a5psw_pcs_free(a5psw);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment