Commit 5a342521 authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger

iscsi-target: Fix indentation + spelling + unreachable code

Modify indentation such that the 'smatch' tool no longer complains
about incorrect indentation + unreachable code.
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: default avatarSagi Grimberg <sagig@mellanox.com>
Reviewed-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent ac75d8be
...@@ -1333,7 +1333,7 @@ iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf, ...@@ -1333,7 +1333,7 @@ iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf,
/* /*
* Check if a delayed TASK_ABORTED status needs to * Check if a delayed TASK_ABORTED status needs to
* be sent now if the ISCSI_FLAG_CMD_FINAL has been * be sent now if the ISCSI_FLAG_CMD_FINAL has been
* received with the unsolicitied data out. * received with the unsolicited data out.
*/ */
if (hdr->flags & ISCSI_FLAG_CMD_FINAL) if (hdr->flags & ISCSI_FLAG_CMD_FINAL)
iscsit_stop_dataout_timer(cmd); iscsit_stop_dataout_timer(cmd);
...@@ -4448,9 +4448,6 @@ int iscsit_close_connection( ...@@ -4448,9 +4448,6 @@ int iscsit_close_connection(
return 0; return 0;
} }
spin_unlock_bh(&sess->conn_lock);
return 0;
} }
int iscsit_close_session(struct iscsi_session *sess) int iscsit_close_session(struct iscsi_session *sess)
......
...@@ -160,8 +160,7 @@ static int iscsit_handle_r2t_snack( ...@@ -160,8 +160,7 @@ static int iscsit_handle_r2t_snack(
" protocol error.\n", cmd->init_task_tag, begrun, " protocol error.\n", cmd->init_task_tag, begrun,
(begrun + runlength), cmd->acked_data_sn); (begrun + runlength), cmd->acked_data_sn);
return iscsit_reject_cmd(cmd, return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
ISCSI_REASON_PROTOCOL_ERROR, buf);
} }
if (runlength) { if (runlength) {
...@@ -628,8 +627,8 @@ int iscsit_dataout_datapduinorder_no_fbit( ...@@ -628,8 +627,8 @@ int iscsit_dataout_datapduinorder_no_fbit(
if (cmd->pdu_list[i].seq_no == pdu->seq_no) { if (cmd->pdu_list[i].seq_no == pdu->seq_no) {
if (!first_pdu) if (!first_pdu)
first_pdu = &cmd->pdu_list[i]; first_pdu = &cmd->pdu_list[i];
xfer_len += cmd->pdu_list[i].length; xfer_len += cmd->pdu_list[i].length;
pdu_count++; pdu_count++;
} else if (pdu_count) } else if (pdu_count)
break; break;
} }
......
...@@ -1668,7 +1668,7 @@ void iscsi_set_session_parameters( ...@@ -1668,7 +1668,7 @@ void iscsi_set_session_parameters(
param->value); param->value);
} else if (!strcmp(param->name, INITIALR2T)) { } else if (!strcmp(param->name, INITIALR2T)) {
ops->InitialR2T = !strcmp(param->value, YES); ops->InitialR2T = !strcmp(param->value, YES);
pr_debug("InitialR2T: %s\n", pr_debug("InitialR2T: %s\n",
param->value); param->value);
} else if (!strcmp(param->name, IMMEDIATEDATA)) { } else if (!strcmp(param->name, IMMEDIATEDATA)) {
ops->ImmediateData = !strcmp(param->value, YES); ops->ImmediateData = !strcmp(param->value, YES);
......
...@@ -82,7 +82,7 @@ int iscsit_tmr_task_warm_reset( ...@@ -82,7 +82,7 @@ int iscsit_tmr_task_warm_reset(
pr_err("TMR Opcode TARGET_WARM_RESET authorization" pr_err("TMR Opcode TARGET_WARM_RESET authorization"
" failed for Initiator Node: %s\n", " failed for Initiator Node: %s\n",
sess->se_sess->se_node_acl->initiatorname); sess->se_sess->se_node_acl->initiatorname);
return -1; return -1;
} }
/* /*
* Do the real work in transport_generic_do_tmr(). * Do the real work in transport_generic_do_tmr().
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment