Commit 5a724772 authored by Grygorii Tertychnyi's avatar Grygorii Tertychnyi Committed by Andi Shyti

i2c: ocores: set IACK bit after core is enabled

Setting IACK bit when core is disabled does not clear the "Interrupt Flag"
bit in the status register, and the interrupt remains pending.

Sometimes it causes failure for the very first message transfer, that is
usually a device probe.

Hence, set IACK bit after core is enabled to clear pending interrupt.

Fixes: 18f98b1e ("[PATCH] i2c: New bus driver for the OpenCores I2C controller")
Signed-off-by: default avatarGrygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>
Acked-by: default avatarPeter Korsgaard <peter@korsgaard.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 5c8cfd59
......@@ -431,8 +431,8 @@ static int ocores_init(struct device *dev, struct ocores_i2c *i2c)
oc_setreg(i2c, OCI2C_PREHIGH, prescale >> 8);
/* Init the device */
oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
oc_setreg(i2c, OCI2C_CONTROL, ctrl | OCI2C_CTRL_EN);
oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
return 0;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment