Commit 5a81e6a1 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Linus Torvalds

vfs: fix uninitialized flags in splice_to_pipe()

Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the
unused part of the pipe ring buffer.  Previously splice_to_pipe() left
the flags value alone, which could result in incorrect behavior.

Uninitialized flags appears to have been there from the introduction of
the splice syscall.
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # 2.6.17+
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 58f6eaee
...@@ -204,6 +204,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe, ...@@ -204,6 +204,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
buf->len = spd->partial[page_nr].len; buf->len = spd->partial[page_nr].len;
buf->private = spd->partial[page_nr].private; buf->private = spd->partial[page_nr].private;
buf->ops = spd->ops; buf->ops = spd->ops;
buf->flags = 0;
pipe->nrbufs++; pipe->nrbufs++;
page_nr++; page_nr++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment