Commit 5be789fc authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

[media] marvell-ccic/mmp-driver.c: simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@
- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent ec532503
...@@ -396,10 +396,6 @@ static int mmpcam_probe(struct platform_device *pdev) ...@@ -396,10 +396,6 @@ static int mmpcam_probe(struct platform_device *pdev)
* Get our I/O memory. * Get our I/O memory.
*/ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
dev_err(&pdev->dev, "no iomem resource!\n");
return -ENODEV;
}
mcam->regs = devm_ioremap_resource(&pdev->dev, res); mcam->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(mcam->regs)) if (IS_ERR(mcam->regs))
return PTR_ERR(mcam->regs); return PTR_ERR(mcam->regs);
...@@ -409,10 +405,6 @@ static int mmpcam_probe(struct platform_device *pdev) ...@@ -409,10 +405,6 @@ static int mmpcam_probe(struct platform_device *pdev)
* should really be managed outside of this driver? * should really be managed outside of this driver?
*/ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 1); res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (res == NULL) {
dev_err(&pdev->dev, "no power resource!\n");
return -ENODEV;
}
cam->power_regs = devm_ioremap_resource(&pdev->dev, res); cam->power_regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(cam->power_regs)) if (IS_ERR(cam->power_regs))
return PTR_ERR(cam->power_regs); return PTR_ERR(cam->power_regs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment