Commit 5beae6ef authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt

tracing: fix ref count in splice pages

The pages allocated for the splice binary buffer did not initialize
the ref count correctly. This caused pages not to be freed and causes
a drastic memory leak.

Thanks to logdev I was able to trace the tracer to find where the leak
was.

[ Impact: stop memory leak when using splice ]
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent cd891ae0
...@@ -3531,6 +3531,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos, ...@@ -3531,6 +3531,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
if (!ref) if (!ref)
break; break;
ref->ref = 1;
ref->buffer = info->tr->buffer; ref->buffer = info->tr->buffer;
ref->page = ring_buffer_alloc_read_page(ref->buffer); ref->page = ring_buffer_alloc_read_page(ref->buffer);
if (!ref->page) { if (!ref->page) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment