Commit 5beb4a07 authored by Dan Carpenter's avatar Dan Carpenter Committed by Luis Henriques

iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb()

commit eda7d0f3 upstream.

"num_read" is in byte units but we are write u16s so we end up write
twice as much as intended.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 50ea922c
...@@ -116,7 +116,7 @@ static int sca3000_read_first_n_hw_rb(struct iio_buffer *r, ...@@ -116,7 +116,7 @@ static int sca3000_read_first_n_hw_rb(struct iio_buffer *r,
if (ret) if (ret)
goto error_ret; goto error_ret;
for (i = 0; i < num_read; i++) for (i = 0; i < num_read / sizeof(u16); i++)
*(((u16 *)rx) + i) = be16_to_cpup((u16 *)rx + i); *(((u16 *)rx) + i) = be16_to_cpup((u16 *)rx + i);
if (copy_to_user(buf, rx, num_read)) if (copy_to_user(buf, rx, num_read))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment