Commit 5dad5ec5 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Benoit Cousson

Documentation: dt: gpio-omap: Move interrupt-controller from #interrupt-cells description

The binding documentation for the OMAP GPIO controller has the
"#interrupt-cells" property listed before "#interrupt-controller"
property but its description after.
This is confusing so we move "#interrupt-cells" after the
"interrupt-controller" property so is followed by its description.

While being there, change the properties order to be consistent with
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
and Documentation/devicetree/bindings/gpio/gpio.txt.

According with these docs, the order of the properties for a gpio-omap
device node should be:

    gpio-controller;
    #gpio-cells = <2>;
    interrupt-controller;
    #interrupt-cells = <2>;
Reported-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: default avatarJon Hunter <jon-hunter@ti.com>
Signed-off-by: default avatarBenoit Cousson <benoit.cousson@linaro.org>
parent 97597b96
...@@ -5,12 +5,12 @@ Required properties: ...@@ -5,12 +5,12 @@ Required properties:
- "ti,omap2-gpio" for OMAP2 controllers - "ti,omap2-gpio" for OMAP2 controllers
- "ti,omap3-gpio" for OMAP3 controllers - "ti,omap3-gpio" for OMAP3 controllers
- "ti,omap4-gpio" for OMAP4 controllers - "ti,omap4-gpio" for OMAP4 controllers
- gpio-controller : Marks the device node as a GPIO controller.
- #gpio-cells : Should be two. - #gpio-cells : Should be two.
- first cell is the pin number - first cell is the pin number
- second cell is used to specify optional parameters (unused) - second cell is used to specify optional parameters (unused)
- gpio-controller : Marks the device node as a GPIO controller. - interrupt-controller: Mark the device node as an interrupt controller.
- #interrupt-cells : Should be 2. - #interrupt-cells : Should be 2.
- interrupt-controller: Mark the device node as an interrupt controller
The first cell is the GPIO number. The first cell is the GPIO number.
The second cell is used to specify flags: The second cell is used to specify flags:
bits[3:0] trigger type and level flags: bits[3:0] trigger type and level flags:
...@@ -29,8 +29,8 @@ Example: ...@@ -29,8 +29,8 @@ Example:
gpio4: gpio4 { gpio4: gpio4 {
compatible = "ti,omap4-gpio"; compatible = "ti,omap4-gpio";
ti,hwmods = "gpio4"; ti,hwmods = "gpio4";
#gpio-cells = <2>;
gpio-controller; gpio-controller;
#interrupt-cells = <2>; #gpio-cells = <2>;
interrupt-controller; interrupt-controller;
#interrupt-cells = <2>;
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment