Commit 5de3bbc8 authored by Michal Suchanek's avatar Michal Suchanek Committed by Rob Herring

of: overlay: add resolver error prints

Applying overlay fails silently in case of an error. Add error prints.
Most notably the lack of symbols in the live tree is not reported.
Signed-off-by: default avatarMichal Suchanek <hramrach@gmail.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 4b681efc
...@@ -315,6 +315,11 @@ int of_resolve_phandles(struct device_node *resolve) ...@@ -315,6 +315,11 @@ int of_resolve_phandles(struct device_node *resolve)
phandle phandle, phandle_delta; phandle phandle, phandle_delta;
int err; int err;
if (!resolve)
pr_err("%s: null node\n", __func__);
if (resolve && !of_node_check_flag(resolve, OF_DETACHED))
pr_err("%s: node %s not detached\n", __func__,
resolve->full_name);
/* the resolve node must exist, and be detached */ /* the resolve node must exist, and be detached */
if (!resolve || !of_node_check_flag(resolve, OF_DETACHED)) if (!resolve || !of_node_check_flag(resolve, OF_DETACHED))
return -EINVAL; return -EINVAL;
...@@ -371,6 +376,7 @@ int of_resolve_phandles(struct device_node *resolve) ...@@ -371,6 +376,7 @@ int of_resolve_phandles(struct device_node *resolve)
/* we need to fixup, but no root symbols... */ /* we need to fixup, but no root symbols... */
if (!root_sym) { if (!root_sym) {
pr_err("%s: no symbols in root of device tree.\n", __func__);
err = -EINVAL; err = -EINVAL;
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment