Commit 5df09c15 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Peter Chen

usb: cdnsp: Fix the IMAN_IE_SET and IMAN_IE_CLEAR macro

IMAN_IE is BIT(1), so these macro are respectively equivalent to BIT(1)
and 0, whatever the value of 'p'.

The purpose was to set and reset a single bit in 'p'.
Fix these macros to do that correctly.
Acked-by: default avatarPawel Laszczak <pawell@cadence.com>
Fixes: e93e58d2 ("usb: cdnsp: Device side header file for CDNSP driver")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d12bfcc9cbffb89e27b120668821b3c4f09b6755.1624390584.git.christophe.jaillet@wanadoo.frSigned-off-by: default avatarPeter Chen <peter.chen@kernel.org>
parent e913aada
......@@ -383,8 +383,8 @@ struct cdnsp_intr_reg {
#define IMAN_IE BIT(1)
#define IMAN_IP BIT(0)
/* bits 2:31 need to be preserved */
#define IMAN_IE_SET(p) (((p) & IMAN_IE) | 0x2)
#define IMAN_IE_CLEAR(p) (((p) & IMAN_IE) & ~(0x2))
#define IMAN_IE_SET(p) ((p) | IMAN_IE)
#define IMAN_IE_CLEAR(p) ((p) & ~IMAN_IE)
/* IMOD - Interrupter Moderation Register - irq_control bitmasks. */
/*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment