Commit 5dfdb089 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Martin K. Petersen

scsi: hpsa: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

Addresses-Coverity-ID: 1195463 ("Missing break in switch")
Addresses-Coverity-ID: 1195464 ("Missing break in switch")
Addresses-Coverity-ID: 1195465 ("Missing break in switch")
Addresses-Coverity-ID: 1195466 ("Missing break in switch")
Addresses-Coverity-ID: 1357338 ("Missing break in switch")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarDon Brace <don.brace@microsemi.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c121c57a
...@@ -4663,6 +4663,7 @@ static int fixup_ioaccel_cdb(u8 *cdb, int *cdb_len) ...@@ -4663,6 +4663,7 @@ static int fixup_ioaccel_cdb(u8 *cdb, int *cdb_len)
case WRITE_6: case WRITE_6:
case WRITE_12: case WRITE_12:
is_write = 1; is_write = 1;
/* fall through */
case READ_6: case READ_6:
case READ_12: case READ_12:
if (*cdb_len == 6) { if (*cdb_len == 6) {
...@@ -5093,6 +5094,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h, ...@@ -5093,6 +5094,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
switch (cmd->cmnd[0]) { switch (cmd->cmnd[0]) {
case WRITE_6: case WRITE_6:
is_write = 1; is_write = 1;
/* fall through */
case READ_6: case READ_6:
first_block = (((cmd->cmnd[1] & 0x1F) << 16) | first_block = (((cmd->cmnd[1] & 0x1F) << 16) |
(cmd->cmnd[2] << 8) | (cmd->cmnd[2] << 8) |
...@@ -5103,6 +5105,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h, ...@@ -5103,6 +5105,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
break; break;
case WRITE_10: case WRITE_10:
is_write = 1; is_write = 1;
/* fall through */
case READ_10: case READ_10:
first_block = first_block =
(((u64) cmd->cmnd[2]) << 24) | (((u64) cmd->cmnd[2]) << 24) |
...@@ -5115,6 +5118,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h, ...@@ -5115,6 +5118,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
break; break;
case WRITE_12: case WRITE_12:
is_write = 1; is_write = 1;
/* fall through */
case READ_12: case READ_12:
first_block = first_block =
(((u64) cmd->cmnd[2]) << 24) | (((u64) cmd->cmnd[2]) << 24) |
...@@ -5129,6 +5133,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h, ...@@ -5129,6 +5133,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
break; break;
case WRITE_16: case WRITE_16:
is_write = 1; is_write = 1;
/* fall through */
case READ_16: case READ_16:
first_block = first_block =
(((u64) cmd->cmnd[2]) << 56) | (((u64) cmd->cmnd[2]) << 56) |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment