Commit 5e02f3b3 authored by H. Nikolaus Schaller's avatar H. Nikolaus Schaller Committed by Greg Kroah-Hartman

w1: omap-hdq: cleanup to add missing newline for some dev_dbg

Otherwise it will corrupt the console log during debugging.

Fixes: 7b5362a6 ("w1: omap_hdq: Fix some error/debug handling.")
Cc: stable@vger.kernel.org
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
Link: https://lore.kernel.org/r/cd0d55749a091214106575f6e1d363c6db56622f.1590255176.git.hns@goldelico.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3234ac66
...@@ -155,7 +155,7 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status) ...@@ -155,7 +155,7 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
/* check irqstatus */ /* check irqstatus */
if (!(*status & OMAP_HDQ_INT_STATUS_TXCOMPLETE)) { if (!(*status & OMAP_HDQ_INT_STATUS_TXCOMPLETE)) {
dev_dbg(hdq_data->dev, "timeout waiting for" dev_dbg(hdq_data->dev, "timeout waiting for"
" TXCOMPLETE/RXCOMPLETE, %x", *status); " TXCOMPLETE/RXCOMPLETE, %x\n", *status);
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
goto out; goto out;
} }
...@@ -166,7 +166,7 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status) ...@@ -166,7 +166,7 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
OMAP_HDQ_FLAG_CLEAR, &tmp_status); OMAP_HDQ_FLAG_CLEAR, &tmp_status);
if (ret) { if (ret) {
dev_dbg(hdq_data->dev, "timeout waiting GO bit" dev_dbg(hdq_data->dev, "timeout waiting GO bit"
" return to zero, %x", tmp_status); " return to zero, %x\n", tmp_status);
} }
out: out:
...@@ -183,7 +183,7 @@ static irqreturn_t hdq_isr(int irq, void *_hdq) ...@@ -183,7 +183,7 @@ static irqreturn_t hdq_isr(int irq, void *_hdq)
spin_lock_irqsave(&hdq_data->hdq_spinlock, irqflags); spin_lock_irqsave(&hdq_data->hdq_spinlock, irqflags);
hdq_data->hdq_irqstatus = hdq_reg_in(hdq_data, OMAP_HDQ_INT_STATUS); hdq_data->hdq_irqstatus = hdq_reg_in(hdq_data, OMAP_HDQ_INT_STATUS);
spin_unlock_irqrestore(&hdq_data->hdq_spinlock, irqflags); spin_unlock_irqrestore(&hdq_data->hdq_spinlock, irqflags);
dev_dbg(hdq_data->dev, "hdq_isr: %x", hdq_data->hdq_irqstatus); dev_dbg(hdq_data->dev, "hdq_isr: %x\n", hdq_data->hdq_irqstatus);
if (hdq_data->hdq_irqstatus & if (hdq_data->hdq_irqstatus &
(OMAP_HDQ_INT_STATUS_TXCOMPLETE | OMAP_HDQ_INT_STATUS_RXCOMPLETE (OMAP_HDQ_INT_STATUS_TXCOMPLETE | OMAP_HDQ_INT_STATUS_RXCOMPLETE
...@@ -248,7 +248,7 @@ static int omap_hdq_break(struct hdq_data *hdq_data) ...@@ -248,7 +248,7 @@ static int omap_hdq_break(struct hdq_data *hdq_data)
tmp_status = hdq_data->hdq_irqstatus; tmp_status = hdq_data->hdq_irqstatus;
/* check irqstatus */ /* check irqstatus */
if (!(tmp_status & OMAP_HDQ_INT_STATUS_TIMEOUT)) { if (!(tmp_status & OMAP_HDQ_INT_STATUS_TIMEOUT)) {
dev_dbg(hdq_data->dev, "timeout waiting for TIMEOUT, %x", dev_dbg(hdq_data->dev, "timeout waiting for TIMEOUT, %x\n",
tmp_status); tmp_status);
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
goto out; goto out;
...@@ -275,7 +275,7 @@ static int omap_hdq_break(struct hdq_data *hdq_data) ...@@ -275,7 +275,7 @@ static int omap_hdq_break(struct hdq_data *hdq_data)
&tmp_status); &tmp_status);
if (ret) if (ret)
dev_dbg(hdq_data->dev, "timeout waiting INIT&GO bits" dev_dbg(hdq_data->dev, "timeout waiting INIT&GO bits"
" return to zero, %x", tmp_status); " return to zero, %x\n", tmp_status);
out: out:
hdq_reset_irqstatus(hdq_data); hdq_reset_irqstatus(hdq_data);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment