Commit 5e23a6fe authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba

btrfs: extent-tree: Remove dead alignment check

In find_free_extent() under checks: label, we have the following code:

		search_start = ALIGN(offset, fs_info->stripesize);
		/* move on to the next group */
		if (search_start + num_bytes >
		    block_group->key.objectid + block_group->key.offset) {
			btrfs_add_free_space(block_group, offset, num_bytes);
			goto loop;
		}
		if (offset < search_start)
			btrfs_add_free_space(block_group, offset,
					     search_start - offset);
		BUG_ON(offset > search_start);

However ALIGN() is rounding up, thus @search_start >= @offset and that
BUG_ON() will never be triggered.
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ca5d2ba1
...@@ -7564,7 +7564,7 @@ static noinline int find_free_extent(struct btrfs_fs_info *fs_info, ...@@ -7564,7 +7564,7 @@ static noinline int find_free_extent(struct btrfs_fs_info *fs_info,
goto loop; goto loop;
} }
checks: checks:
search_start = ALIGN(offset, fs_info->stripesize); search_start = round_up(offset, fs_info->stripesize);
/* move on to the next group */ /* move on to the next group */
if (search_start + num_bytes > if (search_start + num_bytes >
...@@ -7576,7 +7576,6 @@ static noinline int find_free_extent(struct btrfs_fs_info *fs_info, ...@@ -7576,7 +7576,6 @@ static noinline int find_free_extent(struct btrfs_fs_info *fs_info,
if (offset < search_start) if (offset < search_start)
btrfs_add_free_space(block_group, offset, btrfs_add_free_space(block_group, offset,
search_start - offset); search_start - offset);
BUG_ON(offset > search_start);
ret = btrfs_add_reserved_bytes(block_group, ram_bytes, ret = btrfs_add_reserved_bytes(block_group, ram_bytes,
num_bytes, delalloc); num_bytes, delalloc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment