Commit 5e4dc4b6 authored by Dave Airlie's avatar Dave Airlie Committed by Greg Kroah-Hartman

drm/udl: use drm_gem_object_put_unlocked.

[ Upstream commit 8f3b4876 ]

When Daniel removed struct_mutex he didn't fix this call to the unlocked
variant which is required since we no longer use struct mutex.

This fixes a bunch of:
WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm]
Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t>
CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2

backtraces when you plug in a udl device.

Fixes: ae358dac (drm/udl: Get rid of dev->struct_mutex usage)
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent cbba1f55
...@@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev, ...@@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
*offset = drm_vma_node_offset_addr(&gobj->base.vma_node); *offset = drm_vma_node_offset_addr(&gobj->base.vma_node);
out: out:
drm_gem_object_put(&gobj->base); drm_gem_object_put_unlocked(&gobj->base);
unlock: unlock:
mutex_unlock(&udl->gem_lock); mutex_unlock(&udl->gem_lock);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment