Commit 5f08dede authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Greg Kroah-Hartman

staging: rtl8192e: fix kconfig dependency warning for RTLLIB_CRYPTO_CCMP

When RTLLIB_CRYPTO_CCMP is enabled and CRYPTO is disabled, it results in
the following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_CCM
  Depends on [n]: CRYPTO [=n]
  Selected by [m]:
  - RTLLIB_CRYPTO_CCMP [=m] && STAGING [=y] && RTLLIB [=m]

WARNING: unmet direct dependencies detected for CRYPTO_AES
  Depends on [n]: CRYPTO [=n]
  Selected by [m]:
  - RTLLIB_CRYPTO_CCMP [=m] && STAGING [=y] && RTLLIB [=m]

The reason is that RTLLIB_CRYPTO_CCMP selects CRYPTO_CCM and CRYPTO_AES
without depending on or selecting CRYPTO while both CRYPTO_CCM and
CRYPTO_ARC4 are subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: e0e3dadd ("staging: r8192e: Fix possible error in configuration")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Link: https://lore.kernel.org/r/20200915095408.28092-1-fazilyildiran@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 49391bf2
...@@ -14,6 +14,7 @@ if RTLLIB ...@@ -14,6 +14,7 @@ if RTLLIB
config RTLLIB_CRYPTO_CCMP config RTLLIB_CRYPTO_CCMP
tristate "Support for rtllib CCMP crypto" tristate "Support for rtllib CCMP crypto"
depends on RTLLIB depends on RTLLIB
select CRYPTO
select CRYPTO_AES select CRYPTO_AES
select CRYPTO_CCM select CRYPTO_CCM
default y default y
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment