Commit 5f221062 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: s526: remove devpriv macro

This macro relies on a local variable having a specific name.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b2abd982
...@@ -211,12 +211,6 @@ struct s526_private { ...@@ -211,12 +211,6 @@ struct s526_private {
unsigned short s526_ai_config; unsigned short s526_ai_config;
}; };
/*
* most drivers define the following macro to make it easy to
* access the private structure.
*/
#define devpriv ((struct s526_private *)dev->private)
static int s526_gpct_rinsn(struct comedi_device *dev, static int s526_gpct_rinsn(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_insn *insn, struct comedi_subdevice *s, struct comedi_insn *insn,
unsigned int *data) unsigned int *data)
...@@ -247,6 +241,7 @@ static int s526_gpct_insn_config(struct comedi_device *dev, ...@@ -247,6 +241,7 @@ static int s526_gpct_insn_config(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int subdev_channel = CR_CHAN(insn->chanspec); /* Unpack chanspec */ int subdev_channel = CR_CHAN(insn->chanspec); /* Unpack chanspec */
int i; int i;
short value; short value;
...@@ -472,6 +467,7 @@ static int s526_gpct_winsn(struct comedi_device *dev, ...@@ -472,6 +467,7 @@ static int s526_gpct_winsn(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_insn *insn, struct comedi_subdevice *s, struct comedi_insn *insn,
unsigned int *data) unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int subdev_channel = CR_CHAN(insn->chanspec); /* Unpack chanspec */ int subdev_channel = CR_CHAN(insn->chanspec); /* Unpack chanspec */
short value; short value;
union cmReg cmReg; union cmReg cmReg;
...@@ -536,6 +532,7 @@ static int s526_ai_insn_config(struct comedi_device *dev, ...@@ -536,6 +532,7 @@ static int s526_ai_insn_config(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int result = -EINVAL; int result = -EINVAL;
if (insn->n < 1) if (insn->n < 1)
...@@ -569,6 +566,7 @@ static int s526_ai_insn_config(struct comedi_device *dev, ...@@ -569,6 +566,7 @@ static int s526_ai_insn_config(struct comedi_device *dev,
static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s, static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int n, i; int n, i;
int chan = CR_CHAN(insn->chanspec); int chan = CR_CHAN(insn->chanspec);
unsigned short value; unsigned short value;
...@@ -619,6 +617,7 @@ static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s, ...@@ -619,6 +617,7 @@ static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
static int s526_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s, static int s526_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int i; int i;
int chan = CR_CHAN(insn->chanspec); int chan = CR_CHAN(insn->chanspec);
unsigned short val; unsigned short val;
...@@ -651,6 +650,7 @@ static int s526_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s, ...@@ -651,6 +650,7 @@ static int s526_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s,
static int s526_ao_rinsn(struct comedi_device *dev, struct comedi_subdevice *s, static int s526_ao_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private;
int i; int i;
int chan = CR_CHAN(insn->chanspec); int chan = CR_CHAN(insn->chanspec);
...@@ -728,6 +728,7 @@ static int s526_dio_insn_config(struct comedi_device *dev, ...@@ -728,6 +728,7 @@ static int s526_dio_insn_config(struct comedi_device *dev,
static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it) static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{ {
const struct s526_board *board = comedi_board(dev); const struct s526_board *board = comedi_board(dev);
struct s526_private *devpriv;
struct comedi_subdevice *s; struct comedi_subdevice *s;
int iobase; int iobase;
int i, n; int i, n;
...@@ -756,12 +757,10 @@ static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -756,12 +757,10 @@ static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it)
dev->board_name = board->name; dev->board_name = board->name;
/* ret = alloc_private(dev, sizeof(*devpriv));
* Allocate the private structure area. alloc_private() is a if (ret)
* convenient macro defined in comedidev.h. return ret;
*/ devpriv = dev->private;
if (alloc_private(dev, sizeof(struct s526_private)) < 0)
return -ENOMEM;
ret = comedi_alloc_subdevices(dev, 4); ret = comedi_alloc_subdevices(dev, 4);
if (ret) if (ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment