Commit 5f2939d9 authored by Toke Høiland-Jørgensen's avatar Toke Høiland-Jørgensen Committed by David S. Miller

sch_api: Change signature of qdisc_tree_reduce_backlog() to use ints

There are now several places where qdisc_tree_reduce_backlog() is called
with a negative number of packets (to signal an increase in number of
packets in the queue). Rather than rely on overflow behaviour, change the
function signature to use signed integers to communicate this usage to
people reading the code.
Signed-off-by: default avatarToke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f04d402f
...@@ -580,8 +580,7 @@ struct Qdisc *dev_graft_qdisc(struct netdev_queue *dev_queue, ...@@ -580,8 +580,7 @@ struct Qdisc *dev_graft_qdisc(struct netdev_queue *dev_queue,
void qdisc_reset(struct Qdisc *qdisc); void qdisc_reset(struct Qdisc *qdisc);
void qdisc_put(struct Qdisc *qdisc); void qdisc_put(struct Qdisc *qdisc);
void qdisc_put_unlocked(struct Qdisc *qdisc); void qdisc_put_unlocked(struct Qdisc *qdisc);
void qdisc_tree_reduce_backlog(struct Qdisc *qdisc, unsigned int n, void qdisc_tree_reduce_backlog(struct Qdisc *qdisc, int n, int len);
unsigned int len);
#ifdef CONFIG_NET_SCHED #ifdef CONFIG_NET_SCHED
int qdisc_offload_dump_helper(struct Qdisc *q, enum tc_setup_type type, int qdisc_offload_dump_helper(struct Qdisc *q, enum tc_setup_type type,
void *type_data); void *type_data);
......
...@@ -758,8 +758,7 @@ static u32 qdisc_alloc_handle(struct net_device *dev) ...@@ -758,8 +758,7 @@ static u32 qdisc_alloc_handle(struct net_device *dev)
return 0; return 0;
} }
void qdisc_tree_reduce_backlog(struct Qdisc *sch, unsigned int n, void qdisc_tree_reduce_backlog(struct Qdisc *sch, int n, int len)
unsigned int len)
{ {
bool qdisc_is_offloaded = sch->flags & TCQ_F_OFFLOADED; bool qdisc_is_offloaded = sch->flags & TCQ_F_OFFLOADED;
const struct Qdisc_class_ops *cops; const struct Qdisc_class_ops *cops;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment