Commit 5f30b2e8 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Jiri Kosina

livepatch: check kzalloc return values

kzalloc() return should always be checked - notably in example code
where this may be seen as reference. On failure of allocation in
livepatch_fix1_dummy_alloc() respectively dummy_alloc() previous
allocation is freed (thanks to Petr Mladek <pmladek@suse.com> for
catching this) and NULL returned.
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Fixes: 439e7271 ("livepatch: introduce shadow variable API")
Acked-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Acked-by: default avatarMiroslav Benes <mbenes@suse.cz>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 3933ec73
...@@ -89,6 +89,11 @@ struct dummy *livepatch_fix1_dummy_alloc(void) ...@@ -89,6 +89,11 @@ struct dummy *livepatch_fix1_dummy_alloc(void)
* pointer to handle resource release. * pointer to handle resource release.
*/ */
leak = kzalloc(sizeof(int), GFP_KERNEL); leak = kzalloc(sizeof(int), GFP_KERNEL);
if (!leak) {
kfree(d);
return NULL;
}
klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL, klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL,
shadow_leak_ctor, leak); shadow_leak_ctor, leak);
......
...@@ -118,6 +118,10 @@ noinline struct dummy *dummy_alloc(void) ...@@ -118,6 +118,10 @@ noinline struct dummy *dummy_alloc(void)
/* Oops, forgot to save leak! */ /* Oops, forgot to save leak! */
leak = kzalloc(sizeof(int), GFP_KERNEL); leak = kzalloc(sizeof(int), GFP_KERNEL);
if (!leak) {
kfree(d);
return NULL;
}
pr_info("%s: dummy @ %p, expires @ %lx\n", pr_info("%s: dummy @ %p, expires @ %lx\n",
__func__, d, d->jiffies_expire); __func__, d, d->jiffies_expire);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment