Commit 5f3fb46b authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter

drm/i915: Kill a goto from sprite disable code

Let's not use goto when a simple if suffices. This is not error handling
code or anything, so the goto looks out of place.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 82284b6b
...@@ -868,7 +868,6 @@ intel_disable_plane(struct drm_plane *plane) ...@@ -868,7 +868,6 @@ intel_disable_plane(struct drm_plane *plane)
struct drm_device *dev = plane->dev; struct drm_device *dev = plane->dev;
struct intel_plane *intel_plane = to_intel_plane(plane); struct intel_plane *intel_plane = to_intel_plane(plane);
struct intel_crtc *intel_crtc; struct intel_crtc *intel_crtc;
int ret = 0;
if (!plane->fb) if (!plane->fb)
return 0; return 0;
...@@ -883,20 +882,18 @@ intel_disable_plane(struct drm_plane *plane) ...@@ -883,20 +882,18 @@ intel_disable_plane(struct drm_plane *plane)
intel_plane->disable_plane(plane, plane->crtc); intel_plane->disable_plane(plane, plane->crtc);
} }
if (!intel_plane->obj) if (intel_plane->obj) {
goto out; if (intel_crtc->active)
intel_wait_for_vblank(dev, intel_plane->pipe);
if (intel_crtc->active)
intel_wait_for_vblank(dev, intel_plane->pipe);
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
intel_unpin_fb_obj(intel_plane->obj); intel_unpin_fb_obj(intel_plane->obj);
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
intel_plane->obj = NULL; intel_plane->obj = NULL;
out: }
return ret; return 0;
} }
static void intel_destroy_plane(struct drm_plane *plane) static void intel_destroy_plane(struct drm_plane *plane)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment