Commit 5f509239 authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann

ieee802154: handle datagram variables as u16

This reverts commit 9abc378c66e3d6f437eed77c1c534cbc183523f7
("ieee802154: 6lowpan: change datagram var types").

The reason is that I forgot the IPv6 fragmentation here. Our MTU of
lowpan interface is 1280 and skb->len should not above of that. If we
reach a payload above 1280 in IPv6 header then we have a IPv6
fragmentation above 802.15.4 6LoWPAN fragmentation. The type "u16" was
fine, instead I added now a WARN_ON_ONCE if skb->len is above MTU which
should never happen otherwise IPv6 on minimum MTU size is broken.
Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent e98d6d62
...@@ -18,7 +18,7 @@ typedef unsigned __bitwise__ lowpan_rx_result; ...@@ -18,7 +18,7 @@ typedef unsigned __bitwise__ lowpan_rx_result;
struct lowpan_create_arg { struct lowpan_create_arg {
u16 tag; u16 tag;
unsigned int d_size; u16 d_size;
const struct ieee802154_addr *src; const struct ieee802154_addr *src;
const struct ieee802154_addr *dst; const struct ieee802154_addr *dst;
}; };
...@@ -29,7 +29,7 @@ struct lowpan_frag_queue { ...@@ -29,7 +29,7 @@ struct lowpan_frag_queue {
struct inet_frag_queue q; struct inet_frag_queue q;
u16 tag; u16 tag;
unsigned int d_size; u16 d_size;
struct ieee802154_addr saddr; struct ieee802154_addr saddr;
struct ieee802154_addr daddr; struct ieee802154_addr daddr;
}; };
......
...@@ -37,7 +37,7 @@ static struct inet_frags lowpan_frags; ...@@ -37,7 +37,7 @@ static struct inet_frags lowpan_frags;
static int lowpan_frag_reasm(struct lowpan_frag_queue *fq, static int lowpan_frag_reasm(struct lowpan_frag_queue *fq,
struct sk_buff *prev, struct net_device *ldev); struct sk_buff *prev, struct net_device *ldev);
static unsigned int lowpan_hash_frag(u16 tag, unsigned int d_size, static unsigned int lowpan_hash_frag(u16 tag, u16 d_size,
const struct ieee802154_addr *saddr, const struct ieee802154_addr *saddr,
const struct ieee802154_addr *daddr) const struct ieee802154_addr *daddr)
{ {
......
...@@ -137,8 +137,8 @@ lowpan_xmit_fragment(struct sk_buff *skb, const struct ieee802154_hdr *wpan_hdr, ...@@ -137,8 +137,8 @@ lowpan_xmit_fragment(struct sk_buff *skb, const struct ieee802154_hdr *wpan_hdr,
static int static int
lowpan_xmit_fragmented(struct sk_buff *skb, struct net_device *ldev, lowpan_xmit_fragmented(struct sk_buff *skb, struct net_device *ldev,
const struct ieee802154_hdr *wpan_hdr, const struct ieee802154_hdr *wpan_hdr, u16 dgram_size,
unsigned int dgram_size, unsigned int dgram_offset) u16 dgram_offset)
{ {
__be16 frag_tag; __be16 frag_tag;
u8 frag_hdr[5]; u8 frag_hdr[5];
...@@ -203,7 +203,7 @@ lowpan_xmit_fragmented(struct sk_buff *skb, struct net_device *ldev, ...@@ -203,7 +203,7 @@ lowpan_xmit_fragmented(struct sk_buff *skb, struct net_device *ldev,
} }
static int lowpan_header(struct sk_buff *skb, struct net_device *ldev, static int lowpan_header(struct sk_buff *skb, struct net_device *ldev,
unsigned int *dgram_size, unsigned int *dgram_offset) u16 *dgram_size, u16 *dgram_offset)
{ {
struct wpan_dev *wpan_dev = lowpan_dev_info(ldev)->wdev->ieee802154_ptr; struct wpan_dev *wpan_dev = lowpan_dev_info(ldev)->wdev->ieee802154_ptr;
struct ieee802154_addr sa, da; struct ieee802154_addr sa, da;
...@@ -253,10 +253,12 @@ netdev_tx_t lowpan_xmit(struct sk_buff *skb, struct net_device *ldev) ...@@ -253,10 +253,12 @@ netdev_tx_t lowpan_xmit(struct sk_buff *skb, struct net_device *ldev)
{ {
struct ieee802154_hdr wpan_hdr; struct ieee802154_hdr wpan_hdr;
int max_single, ret; int max_single, ret;
unsigned int dgram_size, dgram_offset; u16 dgram_size, dgram_offset;
pr_debug("package xmit\n"); pr_debug("package xmit\n");
WARN_ON_ONCE(skb->len > IPV6_MIN_MTU);
/* We must take a copy of the skb before we modify/replace the ipv6 /* We must take a copy of the skb before we modify/replace the ipv6
* header as the header could be used elsewhere * header as the header could be used elsewhere
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment