Commit 5f7c2bee authored by Bill Kuzeja's avatar Bill Kuzeja Committed by Martin K. Petersen

scsi: qla2xxx: Fix crash in qla2xxx_eh_abort on bad ptr

After a Qlogic card breaks when initializing (test case), the system can
crash in qla2xxx_eh_abort if processing anything but a scsi command type
srb.

Fixes: 1535aa75 ("scsi: qla2xxx: fix invalid DMA access after command aborts in PCI device remove")
Signed-off-by: default avatarBill Kuzeja <william.kuzeja@stratus.com>
Acked-By: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7d708033
...@@ -1617,7 +1617,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) ...@@ -1617,7 +1617,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res)
/* Don't abort commands in adapter during EEH /* Don't abort commands in adapter during EEH
* recovery as it's not accessible/responding. * recovery as it's not accessible/responding.
*/ */
if (GET_CMD_SP(sp) && !ha->flags.eeh_busy) { if (GET_CMD_SP(sp) && !ha->flags.eeh_busy &&
(sp->type == SRB_SCSI_CMD)) {
/* Get a reference to the sp and drop the lock. /* Get a reference to the sp and drop the lock.
* The reference ensures this sp->done() call * The reference ensures this sp->done() call
* - and not the call in qla2xxx_eh_abort() - * - and not the call in qla2xxx_eh_abort() -
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment