Commit 5f8e4474 authored by Kangjie Lu's avatar Kangjie Lu Committed by David S. Miller

net: fix infoleak in rtnetlink

The stack object “map” has a total size of 32 bytes. Its last 4
bytes are padding generated by compiler. These padding bytes are
not initialized and sent out via “nla_put”.
Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b8670c09
...@@ -1180,14 +1180,16 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, ...@@ -1180,14 +1180,16 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
static int rtnl_fill_link_ifmap(struct sk_buff *skb, struct net_device *dev) static int rtnl_fill_link_ifmap(struct sk_buff *skb, struct net_device *dev)
{ {
struct rtnl_link_ifmap map = { struct rtnl_link_ifmap map;
.mem_start = dev->mem_start,
.mem_end = dev->mem_end, memset(&map, 0, sizeof(map));
.base_addr = dev->base_addr, map.mem_start = dev->mem_start;
.irq = dev->irq, map.mem_end = dev->mem_end;
.dma = dev->dma, map.base_addr = dev->base_addr;
.port = dev->if_port, map.irq = dev->irq;
}; map.dma = dev->dma;
map.port = dev->if_port;
if (nla_put(skb, IFLA_MAP, sizeof(map), &map)) if (nla_put(skb, IFLA_MAP, sizeof(map), &map))
return -EMSGSIZE; return -EMSGSIZE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment