Commit 60f9b5e8 authored by Tobias Klauser's avatar Tobias Klauser Committed by David S. Miller

net: xilinx: emaclite: Remove xemaclite_remove_ndev()

xemaclite_remove_ndev() is a simple wrapper around free_netdev()
checking for NULL before the call. All possible paths calling
it are guaranteed to pass a non-NULL argument, so rather call
free_netdev() directly.
Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent aa884a26
...@@ -1028,20 +1028,6 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev) ...@@ -1028,20 +1028,6 @@ static int xemaclite_send(struct sk_buff *orig_skb, struct net_device *dev)
return 0; return 0;
} }
/**
* xemaclite_remove_ndev - Free the network device
* @ndev: Pointer to the network device to be freed
*
* This function un maps the IO region of the Emaclite device and frees the net
* device.
*/
static void xemaclite_remove_ndev(struct net_device *ndev)
{
if (ndev) {
free_netdev(ndev);
}
}
/** /**
* get_bool - Get a parameter from the OF device * get_bool - Get a parameter from the OF device
* @ofdev: Pointer to OF device structure * @ofdev: Pointer to OF device structure
...@@ -1172,7 +1158,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) ...@@ -1172,7 +1158,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
return 0; return 0;
error: error:
xemaclite_remove_ndev(ndev); free_netdev(ndev);
return rc; return rc;
} }
...@@ -1204,7 +1190,7 @@ static int xemaclite_of_remove(struct platform_device *of_dev) ...@@ -1204,7 +1190,7 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
of_node_put(lp->phy_node); of_node_put(lp->phy_node);
lp->phy_node = NULL; lp->phy_node = NULL;
xemaclite_remove_ndev(ndev); free_netdev(ndev);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment