Commit 610ecfd6 authored by Tom St Denis's avatar Tom St Denis Committed by Alex Deucher

drm/amd/powerplay: Fix up return codes in cz SMU manager

Signed-off-by: default avatarTom St Denis <tom.stdenis@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a3477255
...@@ -101,12 +101,12 @@ static int cz_set_smc_sram_address(struct pp_smumgr *smumgr, ...@@ -101,12 +101,12 @@ static int cz_set_smc_sram_address(struct pp_smumgr *smumgr,
if (0 != (3 & smc_address)) { if (0 != (3 & smc_address)) {
printk(KERN_ERR "[ powerplay ] SMC address must be 4 byte aligned\n"); printk(KERN_ERR "[ powerplay ] SMC address must be 4 byte aligned\n");
return -1; return -EINVAL;
} }
if (limit <= (smc_address + 3)) { if (limit <= (smc_address + 3)) {
printk(KERN_ERR "[ powerplay ] SMC address beyond the SMC RAM area\n"); printk(KERN_ERR "[ powerplay ] SMC address beyond the SMC RAM area\n");
return -1; return -EINVAL;
} }
cgs_write_register(smumgr->device, mmMP0PUB_IND_INDEX_0, cgs_write_register(smumgr->device, mmMP0PUB_IND_INDEX_0,
...@@ -124,9 +124,10 @@ static int cz_write_smc_sram_dword(struct pp_smumgr *smumgr, ...@@ -124,9 +124,10 @@ static int cz_write_smc_sram_dword(struct pp_smumgr *smumgr,
return -EINVAL; return -EINVAL;
result = cz_set_smc_sram_address(smumgr, smc_address, limit); result = cz_set_smc_sram_address(smumgr, smc_address, limit);
cgs_write_register(smumgr->device, mmMP0PUB_IND_DATA_0, value); if (!result)
cgs_write_register(smumgr->device, mmMP0PUB_IND_DATA_0, value);
return 0; return result;
} }
static int cz_send_msg_to_smc_with_parameter(struct pp_smumgr *smumgr, static int cz_send_msg_to_smc_with_parameter(struct pp_smumgr *smumgr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment