Commit 6121ca57 authored by Jean-François Moine's avatar Jean-François Moine Committed by Mauro Carvalho Chehab

[media] gspca: Remove the useless variable 'nbalt'

As the alternate settings are now sorted in gspca main,
the variable 'nbalt' is no more useful.
Signed-off-by: default avatarJean-François Moine <moinejf@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a6764879
...@@ -134,13 +134,17 @@ static int sd_start(struct gspca_dev *gspca_dev) ...@@ -134,13 +134,17 @@ static int sd_start(struct gspca_dev *gspca_dev)
static void sd_stopN(struct gspca_dev *gspca_dev) static void sd_stopN(struct gspca_dev *gspca_dev)
{ {
struct usb_interface *intf;
reg_w(gspca_dev, 0x003c, 0x0003); reg_w(gspca_dev, 0x003c, 0x0003);
reg_w(gspca_dev, 0x003c, 0x0004); reg_w(gspca_dev, 0x003c, 0x0004);
reg_w(gspca_dev, 0x003c, 0x0005); reg_w(gspca_dev, 0x003c, 0x0005);
reg_w(gspca_dev, 0x003c, 0x0006); reg_w(gspca_dev, 0x003c, 0x0006);
reg_w(gspca_dev, 0x003c, 0x0007); reg_w(gspca_dev, 0x003c, 0x0007);
intf = usb_ifnum_to_if(gspca_dev->dev, gspca_dev->iface);
usb_set_interface(gspca_dev->dev, gspca_dev->iface, usb_set_interface(gspca_dev->dev, gspca_dev->iface,
gspca_dev->nbalt - 1); intf->num_altsetting - 1);
} }
static void sd_pkt_scan(struct gspca_dev *gspca_dev, static void sd_pkt_scan(struct gspca_dev *gspca_dev,
......
...@@ -337,7 +337,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -337,7 +337,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
return -1; return -1;
cam = &gspca_dev->cam; cam = &gspca_dev->cam;
gspca_dev->nbalt = 4;
switch (sd->sensor) { switch (sd->sensor) {
case ID_MI1320: case ID_MI1320:
......
...@@ -880,7 +880,7 @@ static int gspca_init_transfer(struct gspca_dev *gspca_dev) ...@@ -880,7 +880,7 @@ static int gspca_init_transfer(struct gspca_dev *gspca_dev)
for (;;) { for (;;) {
if (alt != gspca_dev->alt) { if (alt != gspca_dev->alt) {
alt = gspca_dev->alt; alt = gspca_dev->alt;
if (gspca_dev->nbalt > 1) { if (intf->num_altsetting > 1) {
ret = usb_set_interface(gspca_dev->dev, ret = usb_set_interface(gspca_dev->dev,
gspca_dev->iface, gspca_dev->iface,
alt); alt);
...@@ -2300,7 +2300,6 @@ int gspca_dev_probe2(struct usb_interface *intf, ...@@ -2300,7 +2300,6 @@ int gspca_dev_probe2(struct usb_interface *intf,
} }
gspca_dev->dev = dev; gspca_dev->dev = dev;
gspca_dev->iface = intf->cur_altsetting->desc.bInterfaceNumber; gspca_dev->iface = intf->cur_altsetting->desc.bInterfaceNumber;
gspca_dev->nbalt = intf->num_altsetting;
/* check if any audio device */ /* check if any audio device */
if (dev->config->desc.bNumInterfaces != 1) { if (dev->config->desc.bNumInterfaces != 1) {
......
...@@ -207,7 +207,6 @@ struct gspca_dev { ...@@ -207,7 +207,6 @@ struct gspca_dev {
char memory; /* memory type (V4L2_MEMORY_xxx) */ char memory; /* memory type (V4L2_MEMORY_xxx) */
__u8 iface; /* USB interface number */ __u8 iface; /* USB interface number */
__u8 alt; /* USB alternate setting */ __u8 alt; /* USB alternate setting */
__u8 nbalt; /* number of USB alternate settings */
u8 audio; /* presence of audio device */ u8 audio; /* presence of audio device */
}; };
......
...@@ -247,9 +247,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -247,9 +247,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
gspca_dev->cam.cam_mode = vga_mode; gspca_dev->cam.cam_mode = vga_mode;
gspca_dev->cam.nmodes = ARRAY_SIZE(vga_mode); gspca_dev->cam.nmodes = ARRAY_SIZE(vga_mode);
gspca_dev->cam.no_urb_create = 1; gspca_dev->cam.no_urb_create = 1;
/* The highest alt setting has an isoc packetsize of 0, so we
don't want to use it */
gspca_dev->nbalt--;
sd->brightness = BRIGHTNESS_DEFAULT; sd->brightness = BRIGHTNESS_DEFAULT;
sd->contrast = CONTRAST_DEFAULT; sd->contrast = CONTRAST_DEFAULT;
......
...@@ -263,7 +263,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -263,7 +263,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
cam->nmodes = ARRAY_SIZE(vga_mode); cam->nmodes = ARRAY_SIZE(vga_mode);
cam->ctrls = sd->ctrls; cam->ctrls = sd->ctrls;
sd->quality = QUALITY_DEF; sd->quality = QUALITY_DEF;
gspca_dev->nbalt = 9; /* use the altsetting 08 */
return 0; return 0;
} }
......
...@@ -376,7 +376,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -376,7 +376,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
cam->bulk_size = BULK_SIZE; cam->bulk_size = BULK_SIZE;
cam->bulk_nurbs = 4; cam->bulk_nurbs = 4;
cam->ctrls = sd->ctrls; cam->ctrls = sd->ctrls;
gspca_dev->nbalt = 1; /* Ignore the bogus isoc alt settings */
sd->resetlevel = 0x2d; /* Set initial resetlevel */ sd->resetlevel = 0x2d; /* Set initial resetlevel */
/* See if the camera supports brightness */ /* See if the camera supports brightness */
...@@ -395,6 +394,14 @@ static int sd_init(struct gspca_dev *gspca_dev) ...@@ -395,6 +394,14 @@ static int sd_init(struct gspca_dev *gspca_dev)
return 0; return 0;
} }
/* function called at start time before URB creation */
static int sd_isoc_init(struct gspca_dev *gspca_dev)
{
gspca_dev->alt = 1; /* Ignore the bogus isoc alt settings */
return gspca_dev->usb_err;
}
/* -- start the camera -- */ /* -- start the camera -- */
static int sd_start(struct gspca_dev *gspca_dev) static int sd_start(struct gspca_dev *gspca_dev)
{ {
...@@ -714,6 +721,7 @@ static const struct sd_desc sd_desc = { ...@@ -714,6 +721,7 @@ static const struct sd_desc sd_desc = {
.nctrls = ARRAY_SIZE(sd_ctrls), .nctrls = ARRAY_SIZE(sd_ctrls),
.config = sd_config, .config = sd_config,
.init = sd_init, .init = sd_init,
.isoc_init = sd_isoc_init,
.start = sd_start, .start = sd_start,
.stopN = sd_stopN, .stopN = sd_stopN,
.dq_callback = sd_dq_callback, .dq_callback = sd_dq_callback,
......
...@@ -1779,10 +1779,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -1779,10 +1779,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
sd->ag_cnt = -1; sd->ag_cnt = -1;
sd->quality = QUALITY_DEF; sd->quality = QUALITY_DEF;
/* if USB 1.1, let some bandwidth for the audio device */
if (gspca_dev->audio && gspca_dev->dev->speed < USB_SPEED_HIGH)
gspca_dev->nbalt--;
INIT_WORK(&sd->work, qual_upd); INIT_WORK(&sd->work, qual_upd);
return 0; return 0;
......
...@@ -451,7 +451,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -451,7 +451,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
} }
cam = &gspca_dev->cam; cam = &gspca_dev->cam;
gspca_dev->nbalt = 7 + 1; /* choose alternate 7 first */
sd->chip_revision = id->driver_info; sd->chip_revision = id->driver_info;
if (sd->chip_revision == Rev012A) { if (sd->chip_revision == Rev012A) {
......
...@@ -6426,10 +6426,6 @@ static int sd_config(struct gspca_dev *gspca_dev, ...@@ -6426,10 +6426,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
gspca_dev->cam.ctrls = sd->ctrls; gspca_dev->cam.ctrls = sd->ctrls;
sd->quality = QUALITY_DEF; sd->quality = QUALITY_DEF;
/* if USB 1.1, let some bandwidth for the audio device */
if (gspca_dev->audio && gspca_dev->dev->speed < USB_SPEED_HIGH)
gspca_dev->nbalt--;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment