Commit 614d651e authored by Sean Young's avatar Sean Young Committed by Mauro Carvalho Chehab

[media] staging: remove todo and replace with lirc_zilog todo

The lirc_zilog driver is the last remaining lirc driver, so the existing
todo is no longer relevant.
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent c52f2ba7
- All drivers should either be ported to ir-core, or dropped entirely 1. Both ir-kbd-i2c and lirc_zilog provide support for RX events for
(see drivers/media/IR/mceusb.c vs. lirc_mceusb.c in lirc cvs for an the chips supported by lirc_zilog. Before moving lirc_zilog out of staging:
example of a previously completed port).
a. ir-kbd-i2c needs a module parameter added to allow the user to tell
- lirc_bt829 uses registers on a Mach64 VT, which has a separate kernel ir-kbd-i2c to ignore Z8 IR units.
framebuffer driver (atyfb) and userland X driver (mach64). It can't
simply be converted to a normal PCI driver, but ideally it should be b. lirc_zilog should provide Rx key presses to the rc core like ir-kbd-i2c
coordinated with the other drivers. does.
Please send patches to:
Jarod Wilson <jarod@wilsonet.com> 2. lirc_zilog module ref-counting need examination. It has not been
Greg Kroah-Hartman <greg@kroah.com> verified that cdev and lirc_dev will take the proper module references on
lirc_zilog to prevent removal of lirc_zilog when the /dev/lircN device node
is open.
(The good news is ref-counting of lirc_zilog internal structures appears to be
complete. Testing has shown the cx18 module can be unloaded out from under
irw + lircd + lirc_dev, with the /dev/lirc0 device node open, with no adverse
effects. The cx18 module could then be reloaded and irw properly began
receiving button presses again and ir_send worked without error.)
3. Bridge drivers, if able, should provide a chip reset() callback
to lirc_zilog via struct IR_i2c_init_data. cx18 and ivtv already have routines
to perform Z8 chip resets via GPIO manipulations. This would allow lirc_zilog
to bring the chip back to normal when it hangs, in the same places the
original lirc_pvr150 driver code does. This is not strictly needed, so it
is not required to move lirc_zilog out of staging.
Note: Both lirc_zilog and ir-kbd-i2c support the Zilog Z8 for IR, as programmed
and installed on Hauppauge products. When working on either module, developers
must consider at least the following bridge drivers which mention an IR Rx unit
at address 0x71 (indicative of a Z8):
ivtv cx18 hdpvr pvrusb2 bt8xx cx88 saa7134
1. Both ir-kbd-i2c and lirc_zilog provide support for RX events for
the chips supported by lirc_zilog. Before moving lirc_zilog out of staging:
a. ir-kbd-i2c needs a module parameter added to allow the user to tell
ir-kbd-i2c to ignore Z8 IR units.
b. lirc_zilog should provide Rx key presses to the rc core like ir-kbd-i2c
does.
2. lirc_zilog module ref-counting need examination. It has not been
verified that cdev and lirc_dev will take the proper module references on
lirc_zilog to prevent removal of lirc_zilog when the /dev/lircN device node
is open.
(The good news is ref-counting of lirc_zilog internal structures appears to be
complete. Testing has shown the cx18 module can be unloaded out from under
irw + lircd + lirc_dev, with the /dev/lirc0 device node open, with no adverse
effects. The cx18 module could then be reloaded and irw properly began
receiving button presses again and ir_send worked without error.)
3. Bridge drivers, if able, should provide a chip reset() callback
to lirc_zilog via struct IR_i2c_init_data. cx18 and ivtv already have routines
to perform Z8 chip resets via GPIO manipulations. This would allow lirc_zilog
to bring the chip back to normal when it hangs, in the same places the
original lirc_pvr150 driver code does. This is not strictly needed, so it
is not required to move lirc_zilog out of staging.
Note: Both lirc_zilog and ir-kbd-i2c support the Zilog Z8 for IR, as programmed
and installed on Hauppauge products. When working on either module, developers
must consider at least the following bridge drivers which mention an IR Rx unit
at address 0x71 (indicative of a Z8):
ivtv cx18 hdpvr pvrusb2 bt8xx cx88 saa7134
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment