Commit 6186c00a authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller

[NET]: Optimize is_valid_ether_addr()

Low level optimization of the comparison with zero address.
On most cpu's faster to use unrolled or rather than a loop
and memcmp. This is in the fastpath of bridge forwarding.
Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 318a924d
...@@ -46,6 +46,15 @@ static inline void eth_copy_and_sum (struct sk_buff *dest, ...@@ -46,6 +46,15 @@ static inline void eth_copy_and_sum (struct sk_buff *dest,
memcpy (dest->data, src, len); memcpy (dest->data, src, len);
} }
/**
* is_zero_ether_addr - Determine if give Ethernet address is all
* zeros.
*/
static inline int is_zero_ether_addr(const u8 *addr)
{
return !(addr[0] | addr[1] | addr[2] | addr[3] | addr[4] | addr[5]);
}
/** /**
* is_valid_ether_addr - Determine if the given Ethernet address is valid * is_valid_ether_addr - Determine if the given Ethernet address is valid
* @addr: Pointer to a six-byte array containing the Ethernet address * @addr: Pointer to a six-byte array containing the Ethernet address
...@@ -56,11 +65,9 @@ static inline void eth_copy_and_sum (struct sk_buff *dest, ...@@ -56,11 +65,9 @@ static inline void eth_copy_and_sum (struct sk_buff *dest,
* *
* Return true if the address is valid. * Return true if the address is valid.
*/ */
static inline int is_valid_ether_addr( const u8 *addr ) static inline int is_valid_ether_addr(const u8 *addr)
{ {
const char zaddr[6] = {0,}; return !(addr[0]&1) && !is_zero_ether_addr(addr);
return !(addr[0]&1) && memcmp( addr, zaddr, 6);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment