Commit 61dd330a authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman

staging: unisys: Only process up to budget amount of responses

>From napi documentation you should only process the amount your
budget allows, if you go over it just wait for the next napi poll
to continue.
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6bb871b6
......@@ -36,6 +36,7 @@
* = 163840 bytes
*/
#define MAX_BUF 163840
#define NAPI_WEIGHT 64
static int visornic_probe(struct visor_device *dev);
static void visornic_remove(struct visor_device *dev);
......@@ -1613,14 +1614,12 @@ drain_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata)
*/
static void
service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
int *rx_work_done)
int *rx_work_done, int budget)
{
unsigned long flags;
struct net_device *netdev;
/* TODO: CLIENT ACQUIRE -- Don't really need this at the
* moment */
for (;;) {
while (*rx_work_done < budget) {
if (!visorchannel_signalremove(devdata->dev->visorchannel,
IOCHAN_FROM_IOPART,
cmdrsp))
......@@ -1709,7 +1708,7 @@ static int visornic_poll(struct napi_struct *napi, int budget)
int rx_count = 0;
send_rcv_posts_if_needed(devdata);
service_resp_queue(devdata->cmdrsp, devdata, &rx_count);
service_resp_queue(devdata->cmdrsp, devdata, &rx_count, budget);
/*
* If there aren't any more packets to receive
......@@ -1893,6 +1892,16 @@ static int visornic_probe(struct visor_device *dev)
goto cleanup_napi_add;
}
/* Let's start our threads to get responses */
netif_napi_add(netdev, &devdata->napi, visornic_poll, NAPI_WEIGHT);
/*
* Note: Interupts have to be enable before the while
* loop below because the napi routine is responsible for
* setting enab_dis_acked
*/
visorbus_enable_channel_interrupts(dev);
err = register_netdev(netdev);
if (err) {
dev_err(&dev->device,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment