Commit 61e977b7 authored by Dmitry Torokhov's avatar Dmitry Torokhov

Input: ar1021_i2c - do not force raising edge IRQ trigger

We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.
Reviewed-By: default avatarChristian Gmeiner <christian.gmeiner@gmail.com>
Tested-by: default avatarMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 95123fc4
...@@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, ...@@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
error = devm_request_threaded_irq(&client->dev, client->irq, error = devm_request_threaded_irq(&client->dev, client->irq,
NULL, ar1021_i2c_irq, NULL, ar1021_i2c_irq,
IRQF_TRIGGER_RISING | IRQF_ONESHOT, IRQF_ONESHOT,
"ar1021_i2c", ar1021); "ar1021_i2c", ar1021);
if (error) { if (error) {
dev_err(&client->dev, dev_err(&client->dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment