Commit 622c2fc1 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Mauro Carvalho Chehab

[media] em28xx: simplify argument passing to em28xx_init_dev()

The 'struct em28xx *' pointer was passed by reference to the
em28xx_init_dev() function, for no reason. Instead, just pass it by
value, which is much more logical and simple.
Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent d07b901f
...@@ -2916,11 +2916,10 @@ void em28xx_release_resources(struct em28xx *dev) ...@@ -2916,11 +2916,10 @@ void em28xx_release_resources(struct em28xx *dev)
* em28xx_init_dev() * em28xx_init_dev()
* allocates and inits the device structs, registers i2c bus and v4l device * allocates and inits the device structs, registers i2c bus and v4l device
*/ */
static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev, static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev,
struct usb_interface *interface, struct usb_interface *interface,
int minor) int minor)
{ {
struct em28xx *dev = *devhandle;
int retval; int retval;
dev->udev = udev; dev->udev = udev;
...@@ -3302,7 +3301,7 @@ static int em28xx_usb_probe(struct usb_interface *interface, ...@@ -3302,7 +3301,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
/* allocate device struct */ /* allocate device struct */
mutex_init(&dev->lock); mutex_init(&dev->lock);
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
retval = em28xx_init_dev(&dev, udev, interface, nr); retval = em28xx_init_dev(dev, udev, interface, nr);
if (retval) { if (retval) {
goto unlock_and_free; goto unlock_and_free;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment